From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pb@pbcl.net>
Received: from hetzner.pbcl.net (mail.pbcl.net [88.198.119.4])
	by mail.openembedded.org (Postfix) with ESMTP id C64826D572
	for <openembedded-core@lists.openembedded.org>;
	Sat,  2 Nov 2013 16:20:23 +0000 (UTC)
Received: from blundell.swaffham-prior.co.uk ([91.216.112.25]
	helo=[192.168.114.7]) by hetzner.pbcl.net with esmtpsa
	(TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256) (Exim 4.80)
	(envelope-from <pb@pbcl.net>)
	id 1Vcdw1-0005pG-BC; Sat, 02 Nov 2013 17:20:25 +0100
Message-ID: <1383409174.8901.65.camel@x121e.pbcl.net>
From: Phil Blundell <pb@pbcl.net>
To: "Burton, Ross" <ross.burton@intel.com>
Date: Sat, 02 Nov 2013 16:19:34 +0000
In-Reply-To: <CAJTo0LYZxDpY=zW5k0Vz83r1-XFXbdHVgvAHB7c+nxd5Pxmn9Q@mail.gmail.com>
References: <1383335233-12366-1-git-send-email-ross.burton@intel.com>
	<1383339883.8901.42.camel@x121e.pbcl.net>
	<CAJTo0LYZxDpY=zW5k0Vz83r1-XFXbdHVgvAHB7c+nxd5Pxmn9Q@mail.gmail.com>
Organization: Phil Blundell Consulting Ltd
X-Mailer: Evolution 3.4.4-3 
Mime-Version: 1.0
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] wipe-sysroot: explain what is being deleted and require confirmation
X-BeenThere: openembedded-core@lists.openembedded.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Patches and discussions about the oe-core layer
	<openembedded-core.lists.openembedded.org>
List-Unsubscribe: <http://lists.openembedded.org/mailman/options/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=unsubscribe>
List-Archive: <http://lists.openembedded.org/pipermail/openembedded-core/>
List-Post: <mailto:openembedded-core@lists.openembedded.org>
List-Help: <mailto:openembedded-core-request@lists.openembedded.org?subject=help>
List-Subscribe: <http://lists.openembedded.org/mailman/listinfo/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Nov 2013 16:20:24 -0000
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On Fri, 2013-11-01 at 23:21 +0000, Burton, Ross wrote:
> On 1 November 2013 21:04, Phil Blundell <pb@pbcl.net> wrote:
> > On Fri, 2013-11-01 at 19:47 +0000, Ross Burton wrote:
> >> Instead of rushing into deleting entire directory trees without any warning,
> >> print the directories and files that will be deleted and require confirmation
> >> from the user (via --force) that they want files to be deleted.
> >
> > "--force" seems like a bit of an odd name for an argument that you have
> > to supply in order for the script to do anything useful.  Why would the
> > user be running a script named "wipe-sysroot" if they didn't want the
> > sysroot to be deleted?
> 
> I'm open to alternative wording but the essence is "don't delete stuff
> if the user does something like wipe-sysroot --help".

How about:

if [ $# -gt 0 ]; then
  echo "Usage: $0" >&2
  exit 1
fi

p.