Re: [PATCH] Modify buildstats to be merged inside buildhistory

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Sun, 2013-11-03 at 11:37 +0000, Stoicescu, CorneliuX wrote:
> > > +BUILDSTATS_BASE = "${BUILDHISTORY_DIR}/buildstats"
> > >  BNFILE = "${BUILDSTATS_BASE}/.buildname"
> > >  DEVFILE = "${BUILDSTATS_BASE}/.device"
> > 
> > so when buildhistory is used, buildstats automatically becomes part of it?
> > 
> > > @@ -33,7 +33,7 @@ def set_bn(e):
> > >
> > >  def get_bn(e):
> > >      with open(e.data.getVar('BNFILE', True)) as f:
> > > -        bn = f.readline()
> > > +        bn = str(f.readline()).split("/")[0]
> > >      return bn
> > >
> > >  def set_device(e):
> > > @@ -175,6 +175,10 @@ python run_buildstats () {
> > >          # set the buildname
> > >
> > ##############################################################
> > ##########
> > >          try:
> > > +            bb.utils.remove(e.data.getVar('BUILDSTATS_BASE', True),
> > > + recurse=True)
> > 
> > 
> > Do we need to remove this?
> > 
> 
> By reworking the buildstats directory structure to not use the build
> date to separate builds, if we don't remove buildstats each time we
> make a new build the information from multiple builds will merge and
> tools like bybootchartguy.py will not work anymore with buildstats. 

I'd have expected that separate directories for each build are still
maintained. Testing locally here, I can use pybootchartgui in the form:

scripts/pybootchartgui/pybootchartgui.py build/tmp/buildstats/core-image-sato-qemux86/201309302155/

and I'd have thought a similar command would still work in buildhistory
since we'd still have the timestamped directory there?

Cheers,

Richard