From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Lu Chong <Chong.Lu@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] makedevs: fix return error value when input invalid arguments
Date: Tue, 05 Nov 2013 08:39:08 +0000 [thread overview]
Message-ID: <1383640748.6271.172.camel@ted> (raw)
In-Reply-To: <5278AD91.70901@windriver.com>
On Tue, 2013-11-05 at 16:34 +0800, Lu Chong wrote:
> There is no function to implement "-q" and "--squash" in source
> code(makedevs.c).
> I also checked in busybox, but I didn't find the function.
> So, may I need to add this function? or remove this options of help
> information.
I kind of guessed this. These kind of details need to be mentioned in
the commit message. Its not good enough to say what changed, you also
need to say why.
Cheers,
Richard
> Best Regards
> Chong
>
> On 11/04/2013 07:40 PM, Richard Purdie wrote:
> > On Mon, 2013-11-04 at 16:41 +0800, Chong.Lu@windriver.com wrote:
> >> From: Lu Chong <Chong.Lu@windriver.com>
> >>
> >> Remove "-q" and "--squash" options of help information.
> > Why are we removing this?
> >
> > Cheers,
> >
> > Richard
> >
> >
> >
> >
>
prev parent reply other threads:[~2013-11-05 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 8:41 [PATCH] makedevs: fix return error value when input invalid arguments Chong.Lu
2013-11-04 11:40 ` Richard Purdie
2013-11-05 8:34 ` Lu Chong
2013-11-05 8:39 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383640748.6271.172.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=Chong.Lu@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox