From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hetzner.pbcl.net (mail.pbcl.net [88.198.119.4]) by mail.openembedded.org (Postfix) with ESMTP id 4DE1E6D44C for ; Thu, 7 Nov 2013 07:28:47 +0000 (UTC) Received: from blundell.swaffham-prior.co.uk ([91.216.112.25] helo=[192.168.114.7]) by hetzner.pbcl.net with esmtpsa (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1VeK0r-0001Tt-0y; Thu, 07 Nov 2013 08:28:48 +0100 Message-ID: <1383809251.8901.151.camel@x121e.pbcl.net> From: Phil Blundell To: Saul Wold Date: Thu, 07 Nov 2013 07:27:31 +0000 In-Reply-To: <1383775339-4220-3-git-send-email-sgw@linux.intel.com> References: <1383775339-4220-1-git-send-email-sgw@linux.intel.com> <1383775339-4220-3-git-send-email-sgw@linux.intel.com> Organization: Phil Blundell Consulting Ltd X-Mailer: Evolution 3.4.4-3 Mime-Version: 1.0 X-Spam_score: -1.0 X-Spam_score_int: -9 X-Spam_bar: - X-Spam_report: Spam detection software, running on the system "hetzner.pbcl.net", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: On Wed, 2013-11-06 at 14:02 -0800, Saul Wold wrote: > This is only built for PPC and not needed, so remove it to fix the QA Issue > > ERROR: QA Issue: binutils: Files/directories were installed but not shipped > /usr/bin/embedspu [...] Content analysis details: (-1.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 3/3] binutils: remove embedsp X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Nov 2013 07:28:48 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2013-11-06 at 14:02 -0800, Saul Wold wrote: > This is only built for PPC and not needed, so remove it to fix the QA Issue > > ERROR: QA Issue: binutils: Files/directories were installed but not shipped > /usr/bin/embedspu The QA error above talks about "embedspu", but both the subject line of your message and the patch itself say that they are removing "embedsp". Is that correct? Also, please add some commentary to the patch explaining why simply adding embedsp{u} to FILES isn't the right thing to do. > +do_install_append_class-target () { > + # we dont really care about embedsp for ppc so remove it > + rm -f ${D}/${bindir}/embedsp || : > +} > + "rm -f" already ignores nonexistent files so I don't think that the "|| :" construct is buying anything. p.