Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Hart, Darren" <darren.hart@intel.com>
Cc: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] kernel: Use hardlinks during do_install for speed
Date: Fri, 08 Nov 2013 16:53:52 +0000	[thread overview]
Message-ID: <1383929632.2345.14.camel@ted> (raw)
In-Reply-To: <1383929280.5378.110.camel@dvhart-mobl4.amr.corp.intel.com>

On Fri, 2013-11-08 at 16:48 +0000, Hart, Darren wrote:
> On Fri, 2013-11-08 at 15:17 +0000, Richard Purdie wrote:
> > Whilst the comment says we can't do this, its incorrect, install operates
> > on WORKDIR and its hard for different parts of WORKDIR to be on different
> 
> Is it hard? Or is it not possible / not supported?

Not really possible unless you try very hard. Its not supported. We
don't even support WORKDIR and sysroot on different disks really.

> My understanding was it was possible and therefor we couldn't hardlink.
> I'm thrilled at the prospect of being wrong there though!

I'm happy enough to decide we don't support it (and we never have).

> > filesystems. Hardlinking instead of copying is therefore a nice performance
> > gain.
> > 
> > Also, completely skip the Documentation directory (adding a dummy Makefile
> > to keep make happy) and tweak the other cp commands to link since if we
> > don't we'd get "this is the same file" type errors from cp for some kernel
> > versions.
> > 
> > For do_install on linux-yocto, this takes it from 227s -> 84s.
> 
> This, and the others, are fantastic improvements, thanks RP!

I'm rather happy to find something we can easily fix :)

Cheers,

Richard



  reply	other threads:[~2013-11-08 16:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-08 15:17 [PATCH] kernel: Use hardlinks during do_install for speed Richard Purdie
2013-11-08 16:48 ` Hart, Darren
2013-11-08 16:53   ` Richard Purdie [this message]
2013-11-09 20:33     ` Andrea Adami
2013-11-09 20:53       ` Andrea Adami

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383929632.2345.14.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=darren.hart@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox