From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (dan.rpsys.net [93.97.175.187]) by mail.openembedded.org (Postfix) with ESMTP id C0E0B6D846 for ; Wed, 13 Nov 2013 09:10:56 +0000 (UTC) Received: from localhost (dan.rpsys.net [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu1) with ESMTP id rAD9Aqb4016833; Wed, 13 Nov 2013 09:10:52 GMT X-Virus-Scanned: Debian amavisd-new at dan.rpsys.net Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id zwRmDf8YgnHe; Wed, 13 Nov 2013 09:10:52 +0000 (GMT) Received: from [192.168.3.10] (rpvlan0 [192.168.3.10]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu1) with ESMTP id rAD9Alia016829 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NOT); Wed, 13 Nov 2013 09:10:49 GMT Message-ID: <1384333844.6460.79.camel@ted> From: Richard Purdie To: Chong.Lu@windriver.com Date: Wed, 13 Nov 2013 09:10:44 +0000 In-Reply-To: <1384330318-14702-1-git-send-email-Chong.Lu@windriver.com> References: <1384330318-14702-1-git-send-email-Chong.Lu@windriver.com> X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] util-linux: Fix QA warnings about ALTERNATIVES X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Nov 2013 09:10:57 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2013-11-13 at 16:11 +0800, Chong.Lu@windriver.com wrote: > From: Lu Chong > > Previously, EXTRA_OECONF would be overwritten by EXTRA_OECONF_class-native > and EXTRA_OECONF_class-nativesdk when we executed `make export-sdk' command. We don't have an export-sdk command do we? > As a result, some applications such as `last', `mesg' and `reset' didn't get > compiled. > > The patch rewrote EXTRA_OECONF_class-native and EXTRA_OECONF_class-nativesdk > variables to fix QA warnings. > > usr/share/man/man1/last.1.util-linux does not exist > usr/share/man/man1/mesg.1.util-linux does not exist > usr/bin/last.util-linux does not exist > usr/bin/mesg.util-linux does not exist > bin/reset does not exist > > Signed-off-by: Lu Chong > --- > meta/recipes-core/util-linux/util-linux_2.23.2.bb | 22 +++++++++++++++++++-- > 1 file changed, 20 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-core/util-linux/util-linux_2.23.2.bb b/meta/recipes-core/util-linux/util-linux_2.23.2.bb > index b5c221b..b9cdc61 100644 > --- a/meta/recipes-core/util-linux/util-linux_2.23.2.bb > +++ b/meta/recipes-core/util-linux/util-linux_2.23.2.bb > @@ -18,5 +18,23 @@ SRC_URI[md5sum] = "39a02ad0b3b37824c394f40930b7aa38" > SRC_URI[sha256sum] = "6c5be3f7beec91b4893de14bbd722886fa2521be5bfa0fc079b749d0018633b1" > > CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as" > -EXTRA_OECONF_class-native += "--disable-fallocate --disable-use-tty-group" > -EXTRA_OECONF_class-nativesdk += "--disable-fallocate --disable-use-tty-group" > +EXTRA_OECONF_class-native = "--disable-use-tty-group \ > + --disable-makeinstall-chown --enable-elvtune --enable-init \ > + --enable-kill --enable-last --enable-mesg --enable-partx \ > + --enable-raw --enable-rdev --enable-reset --disable-login \ > + --disable-vipw --disable-newgrp --disable-chfn-chsh \ > + --enable-write --enable-arch --enable-mount --with-fsprobe=builtin \ > + --enable-libuuid --enable-libblkid --enable-fsck --without-udev \ > + usrsbin_execdir='${sbindir}' \ > + --disable-fallocate --disable-use-tty-group \ > +" > +EXTRA_OECONF_class-nativesdk = "--disable-use-tty-group \ > + --disable-makeinstall-chown --enable-elvtune --enable-init \ > + --enable-kill --enable-last --enable-mesg --enable-partx \ > + --enable-raw --enable-rdev --enable-reset --disable-login \ > + --disable-vipw --disable-newgrp --disable-chfn-chsh \ > + --enable-write --enable-arch --enable-mount --with-fsprobe=builtin \ > + --enable-libuuid --enable-libblkid --enable-fsck --without-udev \ > + usrsbin_execdir='${sbindir}' \ > + --disable-fallocate --disable-use-tty-group \ > +" We are not duplicating EXTRA_OECONF like that, its horrible. How about something like: EXTRA_OECONF = "xxxx ${SOMEVAR}" SOMEVAR = "z" SOMEVAR_class-native = "x" SOMEVAR_class-nativesdk = "y" ? I'm having to guess at what your real problem is though as the commit message doesn't contain the right information. Cheers, Richard