From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Laurentiu Palcu <laurentiu.palcu@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2 1/1] flex: fix m4 issue on target
Date: Thu, 14 Nov 2013 13:19:10 +0000 [thread overview]
Message-ID: <1384435150.6460.124.camel@ted> (raw)
In-Reply-To: <20131114124302.GA7503@lpalcu-linux>
On Thu, 2013-11-14 at 14:43 +0200, Laurentiu Palcu wrote:
> Even though this was in the last C-pull, for some reason, it didn't end
> up in master... Didn't see any comments on it either. Or maybe I missed
> them...
In the target case, M4 should be compiled in as ${bindir}/m4 and there
should be no need of a wrapper. Can someone confirm this is the case? Is
the OEMAKE command only used for compilation and not built into the
target?
Cheers,
Richard
> Thanks,
> Laurentiu
>
> On Wed, Nov 06, 2013 at 03:07:58PM +0200, Laurentiu Palcu wrote:
> > Flex needs m4 to run (see below) and, since the create_wrapper
> > introduces a bash dependency on target, give the path to m4 binary in
> > the configure command line.
> >
> > Snippet from the flex documentation:
> > "The macro processor m4 must be installed wherever flex is installed.
> > <...>
> > m4 is only required at the time you run flex."
> >
> > [YOCTO #5329]
> >
> > Signed-off-by: Laurentiu Palcu <laurentiu.palcu@intel.com>
> > ---
> > meta/recipes-devtools/flex/flex.inc | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/meta/recipes-devtools/flex/flex.inc b/meta/recipes-devtools/flex/flex.inc
> > index 43f1dda..96d5de5 100644
> > --- a/meta/recipes-devtools/flex/flex.inc
> > +++ b/meta/recipes-devtools/flex/flex.inc
> > @@ -13,6 +13,9 @@ inherit autotools gettext
> > M4 = "${bindir}/m4"
> > M4_class-native = "${STAGING_BINDIR_NATIVE}/m4"
> >
> > +EXTRA_OECONF += "ac_cv_path_M4=${M4}"
> > +EXTRA_OEMAKE += "m4=${STAGING_BINDIR_NATIVE}/m4"
> > +
> > do_install_append_class-native() {
> > create_wrapper ${D}/${bindir}/flex M4=${M4}
> > }
> > @@ -20,3 +23,5 @@ do_install_append_class-native() {
> > do_install_append_class-nativesdk() {
> > create_wrapper ${D}/${bindir}/flex M4=${M4}
> > }
> > +
> > +RDEPENDS_${PN} += "m4"
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
next prev parent reply other threads:[~2013-11-14 13:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 13:07 [PATCH v2 0/1] flex: fix m4 issue on target Laurentiu Palcu
2013-11-06 13:07 ` [PATCH v2 1/1] " Laurentiu Palcu
2013-11-14 12:43 ` Laurentiu Palcu
2013-11-14 13:19 ` Richard Purdie [this message]
2013-11-14 13:52 ` Laurentiu Palcu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384435150.6460.124.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=laurentiu.palcu@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox