From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hetzner.pbcl.net (mail.pbcl.net [88.198.119.4]) by mail.openembedded.org (Postfix) with ESMTP id B2E096D571 for ; Thu, 14 Nov 2013 16:04:11 +0000 (UTC) Received: from cpc6-cmbg17-2-0-cust487.5-4.cable.virginm.net ([86.30.57.232] helo=[172.30.1.45]) by hetzner.pbcl.net with esmtpsa (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1VgzOu-0001Mn-Ny; Thu, 14 Nov 2013 17:04:13 +0100 Message-ID: <1384445052.17320.76.camel@phil-desktop.brightsign> From: Phil Blundell To: Mark Hatle Date: Thu, 14 Nov 2013 16:04:12 +0000 In-Reply-To: <5284F119.8010903@windriver.com> References: <5284CFAD.2060903@mlbassoc.com> <1384436557.17320.62.camel@phil-desktop.brightsign> <5284F119.8010903@windriver.com> X-Mailer: Evolution 3.4.4-4+b1 Mime-Version: 1.0 X-Spam_score: -1.0 X-Spam_score_int: -9 X-Spam_bar: - X-Spam_report: Spam detection software, running on the system "hetzner.pbcl.net", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: On Thu, 2013-11-14 at 09:49 -0600, Mark Hatle wrote: > On 11/14/13, 7:42 AM, Phil Blundell wrote: > > On Thu, 2013-11-14 at 06:27 -0700, Gary Thomas wrote: > >> Also, is "-" actually valid? I seem to recall having problems when my build > >> tree had the hyphen ("-") in the path. > > > > Paths with "-" in certainly work for me. If there are any recipes which > > break in that situation then we should just fix them. > > We found an issue with paths that -start- with a '-', there are apparently many > places where paths are passed into various shell, and the initial '-' can be > read as an argument identifier. [...] Content analysis details: (-1.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 1/1] sanity.bbclass: check for validity of TMPDIR X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Nov 2013 16:04:12 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Thu, 2013-11-14 at 09:49 -0600, Mark Hatle wrote: > On 11/14/13, 7:42 AM, Phil Blundell wrote: > > On Thu, 2013-11-14 at 06:27 -0700, Gary Thomas wrote: > >> Also, is "-" actually valid? I seem to recall having problems when my build > >> tree had the hyphen ("-") in the path. > > > > Paths with "-" in certainly work for me. If there are any recipes which > > break in that situation then we should just fix them. > > We found an issue with paths that -start- with a '-', there are apparently many > places where paths are passed into various shell, and the initial '-' can be > read as an argument identifier. Right, I can imagine that this would break fairly badly. But if we're going to require TMPDIR to be an absolute path (which seems perfectly reasonable) then by definition it can't start with - so this will presumably become a non-issue. > I don't believe Qi Chen sent it to the list, but we built path names with all of > the special characters and tried to run builds. The specific list is based on > the results of those tests. The other items are already broken, and we're > trying to be explicit with this for end users. (Note, it's really the TMPDIR > that matters.. the 'build' directory is a lot more flexible.) Yeah, I saw the results of those tests. My slight reservation with that methodology is that, if any single recipe fails with a given character in TMPDIR, no matter how obscure that recipe might be, it seems that this is enough to make that character verboten. For example, the rationale for excluding "+" seems to be that it breaks tcl; if this is the only recipe that fails then it seems like it might be worth at least trying to fix tcl rather than excluding "+" from TMPDIRs for ever more. But, clearly, there are some characters in the list that are "just silly" to have in pathnames. I don't think anybody would be surprised to learn that "*" and "$" cause problems and blacklisting those ones does seem quite reasonable. p.