Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 4/7] linux-firmware: Drop allarch
Date: Mon, 18 Nov 2013 10:57:53 +0000	[thread overview]
Message-ID: <1384772273.6460.194.camel@ted> (raw)
In-Reply-To: <1384696338-5390-4-git-send-email-Martin.Jansa@gmail.com>

On Sun, 2013-11-17 at 14:52 +0100, Martin Jansa wrote:
> * the recipe itself is allarch, but update-alternatives adds dependency on
>   virtual/${MLPREFIX}update-alternatives which can be TUNE_PKGARCH opkg
>   causing linux-firmware signature to be different for different TUNE_PKGARCHs
>   Hash for dependent task opkg_svn.bb.do_populate_sysroot changed from 8d215059308161841a84542dd1dcbf3a to 80b280c741c392cf5b30dd67b61dd56e
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/recipes-kernel/linux-firmware/linux-firmware_git.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
> index e3a099a..ebb9c81 100644
> --- a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
> +++ b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
> @@ -32,7 +32,7 @@ SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware
>  
>  S = "${WORKDIR}/git"
>  
> -inherit allarch update-alternatives
> +inherit update-alternatives

I think this is one case where we should whitelist update-alternatives
as being ABI/API safe instead. There is no point in building the
firmware multiple times.

Cheers,

Richard



  reply	other threads:[~2013-11-18 10:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-01 12:12 [RFC][PATCH] packagegroup.bbclass: Drop build-time dependencies Martin Jansa
2013-11-01 13:37 ` Paul Eggleton
2013-11-01 18:14   ` Richard Purdie
2013-11-01 19:06     ` Paul Eggleton
2013-11-17 13:52 ` [PATCH 1/7] allarch: Always inhibit default dependencies and set empty TARGET_PREFIX Martin Jansa
2013-11-17 13:52   ` [PATCH 2/7] packagegroup-core-boot: Drop build-time dependency on virtual/kernel Martin Jansa
2013-11-20  5:57     ` ChenQi
2013-11-17 13:52   ` [PATCH 3/7] xuser-account: Drop allarch inherit Martin Jansa
2013-11-17 13:52   ` [PATCH 4/7] linux-firmware: Drop allarch Martin Jansa
2013-11-18 10:57     ` Richard Purdie [this message]
2013-11-17 13:52   ` [PATCH 5/7] ppp-dialin: " Martin Jansa
2013-11-17 13:52   ` [PATCH 6/7] initramfs-framework: " Martin Jansa
2013-11-17 13:52   ` [PATCH 7/7] resolvconf: " Martin Jansa
2013-11-18 12:31   ` [PATCH 1/7] allarch: Always inhibit default dependencies and set empty TARGET_PREFIX Richard Purdie
2013-11-18 15:54     ` Martin Jansa
2013-11-18 15:58       ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384772273.6460.194.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox