Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Bruce Ashfield <bruce.ashfield@gmail.com>
Cc: Mike Crowe <mac@mcrowe.com>,
	Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/2] kernel.bbclass: Call make with correct variables in kernelscripts_sstate_postinst
Date: Tue, 19 Nov 2013 17:46:16 +0000	[thread overview]
Message-ID: <1384883176.16887.9.camel@ted> (raw)
In-Reply-To: <CADkTA4MQF4be4RO0vm=a2Rv404M9sjK6ZFE7V0hV_gDBX5hvMQ@mail.gmail.com>

On Tue, 2013-11-19 at 12:41 -0500, Bruce Ashfield wrote:
> On Tue, Nov 19, 2013 at 12:37 PM, Mike Crowe <mac@mcrowe.com> wrote:
> > Ensure that the environment variable and command line arguments that are
> > used when calling make in kernel_do_compile are used in
> > kernelscripts_sstate_postinst.
> 
> What issue was this causing for you ? The scripts are native, and hence
> should just be using the build machines compiler, linker and don't need
> the kernel args.
> 
> So I'm not convinced that we need this patch, without seeing a tangible
> issue that was triggered.

I think for some arches at least, something targetish is being cleaned
and then needing to be rebuilt.

I don't want to have to add dependencies for the toolchain so we need to
look into this further. 

Mike: which arch was this on and do you have the compile error?

Cheers,

Richard



  reply	other threads:[~2013-11-19 17:46 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-08 21:12 [PATCH 0/1] kernel: restore scripts in the sysroot Bruce Ashfield
2013-10-08 21:12 ` [PATCH 1/1] " Bruce Ashfield
2013-11-19 17:37   ` Mike Crowe
2013-11-19 17:37     ` [PATCH 1/2] kernel.bbclass: Ensure compiler is available for do_populate_sysroot_setscene Mike Crowe
2013-11-19 17:37       ` [PATCH 2/2] kernel.bbclass: Call make with correct variables in kernelscripts_sstate_postinst Mike Crowe
2013-11-19 17:41         ` Bruce Ashfield
2013-11-19 17:46           ` Richard Purdie [this message]
2013-11-19 17:56             ` Bruce Ashfield
2013-11-19 17:49           ` Mike Crowe
2013-11-19 17:59             ` Phil Blundell
2013-11-19 17:47       ` [PATCH 1/2] kernel.bbclass: Ensure compiler is available for do_populate_sysroot_setscene Bruce Ashfield
2013-11-19 17:46     ` [PATCH 1/1] kernel: restore scripts in the sysroot Phil Blundell
2013-11-19 17:54       ` Bruce Ashfield
2013-11-19 18:17         ` Bruce Ashfield
2013-11-19 22:29           ` Khem Raj
2013-11-19 22:36             ` Richard Purdie
2013-11-19 22:39               ` Khem Raj
2013-11-19 22:45                 ` Richard Purdie
2013-11-20  2:59                   ` Khem Raj
2013-11-20  4:43                     ` Bruce Ashfield
2013-11-19 22:37             ` Bruce Ashfield
2013-11-19 22:42               ` Richard Purdie
2013-11-19 22:46                 ` Bruce Ashfield
2013-11-19 23:44               ` Phil Blundell
2013-11-19 22:48                 ` Bruce Ashfield
2013-11-19 23:41             ` Phil Blundell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384883176.16887.9.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bruce.ashfield@gmail.com \
    --cc=mac@mcrowe.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox