Re: [master][dora][PATCH 1/2] perf: disallow debug optimization.

[Phil Blundell <pb@pbcl.net>]

On Thu, 2013-11-21 at 15:57 +0000, Phil Blundell wrote:
> On Thu, 2013-11-21 at 08:47 -0600, Mark Hatle wrote:
> > We have users who desire to build their system at different levels of 
> > optimizations for debug, size, profiling, etc.  So they do change the default 
> > optimization levels from -O2 to -O0, etc.  The python fragement is used to only 
> > adjust -O0, as -O1 (or -Os) work correctly.
> 
> Sure, I understand what the python is doing.  The things I'm not quite
> so clear about are:
> 
> a) If the user asks to build with -O0, is it appropriate for the
> metadata to second-guess this and quietly switch to using -O2 instead
> when it thinks it knows best?  

I suppose the other question is: why exactly does perf fail to build at
-O0, and can we just patch it so that it works rather than forcing
optimisation on?  Even if it can't be fixed, it would be good for the
commit message associated with any workaround to explain what the
problem is.

p.