From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (dan.rpsys.net [93.97.175.187]) by mail.openembedded.org (Postfix) with ESMTP id 502A760F50 for ; Fri, 22 Nov 2013 23:17:28 +0000 (UTC) Received: from localhost (dan.rpsys.net [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu1) with ESMTP id rAMNHMUe003147; Fri, 22 Nov 2013 23:17:22 GMT X-Virus-Scanned: Debian amavisd-new at dan.rpsys.net Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id TcRX1Th3Kwpv; Fri, 22 Nov 2013 23:17:21 +0000 (GMT) Received: from [192.168.3.10] (rpvlan0 [192.168.3.10]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu1) with ESMTP id rAMNHG8f003143 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NOT); Fri, 22 Nov 2013 23:17:17 GMT Message-ID: <1385162232.16887.191.camel@ted> From: Richard Purdie To: Otavio Salvador Date: Fri, 22 Nov 2013 23:17:12 +0000 In-Reply-To: References: <1385132854.16887.178.camel@ted> X-Mailer: Evolution 3.6.4-0ubuntu1 Mime-Version: 1.0 Cc: openembedded-core Subject: Re: [PATCH] metadata_scm: Avoid crashing on new svn version layouts X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Nov 2013 23:17:30 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Fri, 2013-11-22 at 16:49 -0200, Otavio Salvador wrote: > On Fri, Nov 22, 2013 at 1:07 PM, Richard Purdie > wrote: > > This avoids crashing on newer svn layouts where the entries files > > don't contain three lines. If someone wants to fix this to > > get the right version on newer subversion checkouts, patches > > welcome but this at least stops things crashing. > > > > [YOCTO #5363] > > > > Signed-off-by: Richard Purdie > > Does not seem right to 'workaround' this; it'd be better to fix it properly. Its bad the system completely crashes and this patch improves/removes that particular problem. Equally, I don't have any inclination to figure out the svn changes, I also don't know anyone with any interest in figuring out svn changes. This has been broken long enough that I don't think many people can be using it. If people are, they will fix it... Cheers, Richard