From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Philip Balister <philip@balister.org>
Cc: openembedded-core@lists.openembedded.org,
openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] cmake: respect ${S} and ${B}
Date: Thu, 05 Dec 2013 22:23:21 +0000 [thread overview]
Message-ID: <1386282201.25847.29.camel@ted> (raw)
In-Reply-To: <52A0FBC5.6090009@balister.org>
On Thu, 2013-12-05 at 17:18 -0500, Philip Balister wrote:
> On 12/04/2013 07:38 PM, Ross Burton wrote:
> > Instead of the class-specific variables OECMAKE_BUILDPATH and
> > OECMAKE_SOURCEPATH, just use ${B} and ${S}.
> >
> > If these two paths are different, delete any existing ${B} before running a
> > build so that previous builds don't taint the current build.
> >
> > Note that OECMAKE_SOURCEPATH and OECMAKE_BUILDPATH are not respected at all, so
> > recipes that manually set these in the past will need to be updated to either
> > use something along the lines of separatebuilddir.inc or set B themselves.
>
> I'm carrying EXTRA_OEMAKE = "-C $(OECMAKE_BUILDPATH)" in recipes. It
> looks like this removes the need for this also? My cmake invocation is
> rusty :)
do_compile runs by default in ${B} so in most cases that shouldn't be
needed. The new equivalent would be "-C ${B}" but that shouldn't be
needed in most cases.
Cheers,
Richard
next prev parent reply other threads:[~2013-12-05 22:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 0:38 [RFC][PATCH] cmake: respect ${S} and ${B} Ross Burton
2013-12-05 0:38 ` [PATCH] " Ross Burton
2013-12-05 22:18 ` Philip Balister
2013-12-05 22:23 ` Richard Purdie [this message]
2013-12-05 0:55 ` [RFC][PATCH] " Martin Jansa
2013-12-05 9:43 ` Koen Kooi
2013-12-05 10:10 ` Richard Purdie
2013-12-05 11:34 ` Martin Jansa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386282201.25847.29.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=openembedded-devel@lists.openembedded.org \
--cc=philip@balister.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox