Re: [PATCH] sstate: Add optimizing logic for crosssdk setscene dependencies

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2013-11-14 at 18:51 +0800, Ming Liu wrote:
> This patch mainly aims to add optimisation for crosssdk setscene dependency
> validating which we haven't handled in current logic, and which I think we
> could have as we've already implemented to native/cross, although there
> are albeit not many crossdk tasks, we could still get some performance
> enhancement.
> 
> And it also fix a vulnerability of some certain workflow, think about the
> following scenario with current logic:
>     bitbake nativesdk-eglibc-initial -c cleansstate
>     bitbake gcc-crosssdk-initial -c clean
>     bitbake gmp-native -c clean
>     bitbake libmpc-native -c clean
>     bitbake mpfr-native -c clean
>     bitbake gcc-crosssdk-initial
>     bitbake nativesdk-eglibc-initial
> 
> Aboving will fail for absence of a few native libraries required by
> gcc-crosssdk-initial.
> 
> Also modified some places in current code except the optimisation, as
> following:
> 1 Remove isNative function since no code is referring it.
> 2 Add do_package to the list that don't exist and are noexec.

I've split this patch up as its doing too many things at once. In
particular, I think we should keep the "isNativeCross()" function name
instead of adding Crosssdk to the name since it just makes things more
confusing to read.

I've take a part for the crosssdk part in master-next which is being
tested at the moment, can you resent the do_package part by itself
please?

I don't quite understand how the sequence of commands above breaks
things or how this patch fixes it. Are you sure this wasn't fixed by:

http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=ciorga/PUs&id=1dcbf3096d7d42032faade96dae89c25a4feca7a

which would be the real bug?

Cheers,

Richard