From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Jacob Kroon <jacob.kroon@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: Strange looking commit in oe-core, 4cee162c292915e
Date: Mon, 06 Jan 2014 13:09:36 +0000 [thread overview]
Message-ID: <1389013776.22784.12.camel@ted> (raw)
In-Reply-To: <alpine.LFD.2.11.1401061314390.9209@localhost.localdomain>
On Mon, 2014-01-06 at 13:25 +0100, Jacob Kroon wrote:
> Hi,
>
> Just an observation from my side, I was looking at the recent commits
> in OE-Core and saw 4cee162c292915e68e8efcab68a31ba0e48105e9,
> "enchant: fix unrecognised option"
>
> The actual commit message doesn't seem to have anything to do with the
> actual patch. Perhaps it has been rebased and gone through some other
> massaging, the patch seems to make sense, at least to me, still it
> would be nice to always have sane commit messages.
It looks like some wires got crossed, yes :( I've pulled it from one of
Saul's branches and shouldn't have done.
We do put quite a lot of effort into keep the standard of commit
messages high. Equally, with the volume of patches coming in and the
pressure to get things merged, the odd issue does creep in :(. More help
in patch aggregation, testing and review would always be appreciated
however its a pretty thankless task :/.
It does look like the change in question is a valid change but simply
doesn't match the description.
Cheers,
Richard
next prev parent reply other threads:[~2014-01-06 13:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 12:25 Strange looking commit in oe-core, 4cee162c292915e Jacob Kroon
2014-01-06 13:09 ` Richard Purdie [this message]
2014-01-06 16:15 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389013776.22784.12.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=jacob.kroon@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox