From: Phil Blundell <pb@pbcl.net>
To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Cc: "OE Core \(openembedded-core@lists.openembedded.org\)"
<openembedded-core@lists.openembedded.org>
Subject: Re: RFC: Maintain backwards compatibility or not for module-base.bbclass
Date: Thu, 16 Jan 2014 21:39:00 +0000 [thread overview]
Message-ID: <1389908340.2467.11.camel@e130.pbcl.net> (raw)
In-Reply-To: <A612847CFE53224C91B23E3A5B48BAC7A5548F1DCE@xmail3.se.axis.com>
On Thu, 2014-01-16 at 14:58 +0100, Peter Kjellerstedt wrote:
> So, here I am now. I do not know who else use the
> do_make_scripts() function from module-base.bbclass and in what
> way, and whether restructuring the functionality into the new
> kernel-scripts.bbclass without maintaining backwards
> compatibility would be a problem. If you know anything about
> this, please let me know.
I'm not entirely clear why you couldn't maintain compatibility by moving
the task in question to a new class but keeping its name the same (i.e.
refrain from renaming "do_make_scripts" to "do_kernel_scripts") and
having module-base.bbclass simply inherit the newly-added class. That
seems like it ought to be fairly straightforward and uncontroversial.
That said, though, I don't think there is any pressing need to maintain
backwards compatibility around module-base.bbclass. In fact, I think it
would probably be fine for module-base.bbclass to simply go away
altogether and have its functionality subsumed into module.bbclass; the
split between those two classes is mostly a relic of yesteryear and I
can't think of any good purpose that it serves nowadays. So I would be
happy enough to see that (and the tangly mess that is the kernel classes
in general) cleaned up irrespective of what happens with
do_make_scripts.
p.
prev parent reply other threads:[~2014-01-16 21:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 13:58 RFC: Maintain backwards compatibility or not for module-base.bbclass Peter Kjellerstedt
2014-01-16 18:40 ` Bruce Ashfield
2014-01-17 13:53 ` Peter Kjellerstedt
2014-01-17 18:07 ` Bruce Ashfield
2014-01-16 19:19 ` Koen Kooi
2014-01-16 21:39 ` Phil Blundell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389908340.2467.11.camel@e130.pbcl.net \
--to=pb@pbcl.net \
--cc=openembedded-core@lists.openembedded.org \
--cc=peter.kjellerstedt@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox