Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 3/5] package.bbclass: add SHLIBSSEARCHDIRS to define where to search for shlib providers
Date: Sun, 19 Jan 2014 17:13:45 +0000	[thread overview]
Message-ID: <1390151625.874.16.camel@ted> (raw)
In-Reply-To: <f689af01e81dd9a6387b8f424ddf55358f846024.1390052636.git.Martin.Jansa@gmail.com>

On Sat, 2014-01-18 at 15:02 +0100, Martin Jansa wrote:
> * when package contains some files matching "^.*\.so", but in directory
>   not default linker search paths (e.g. /opt/package/bundled-lib/libfoo.so)
>   don't register it as libfoo provider, because it's possible that there
>   is different package providing libfoo.so in ${libdir} and that would
>   be better shlib provider for other packages to depend on
> * recipes providing libs intentionally in some other directory can
>   define own SHLIBSSEARCHDIRS value
> 
> [YOCTO #4628]
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/classes/package.bbclass | 26 +++++++++++++++++++++++---
>  1 file changed, 23 insertions(+), 3 deletions(-)

Doesn't this mean we lose automatic dependencies for libraries not in
the default system paths after this change?

We should really be respecting the libraries RPATH in this code and
searching the places it will look...

Cheers,

Richard



  reply	other threads:[~2014-01-19 17:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-18 14:02 [PATCH 0/5] shlibs providers improvements Martin Jansa
2014-01-18 14:02 ` [PATCH 1/5] package.bbclass: move reading shlibs providers to separate function Martin Jansa
2014-01-18 14:02 ` [PATCH 2/5] package.bbclass: show warning when package is trying to provide already provided shlib Martin Jansa
2014-01-19 13:13   ` Martin Jansa
     [not found]   ` <cover.1390138091.git.Martin.Jansa@gmail.com>
2014-01-19 13:28     ` [PATCHv2 " Martin Jansa
2014-01-19 14:42       ` Phil Blundell
2014-01-19 15:23         ` [PATCHv2 3/5] package.bbclass: add SHLIBSSEARCHDIRS to define where to search for shlib providers Martin Jansa
2014-01-19 15:25           ` Martin Jansa
2014-01-19 15:24         ` [PATCHv3 2/5] package.bbclass: show warning when package is providing already provided shlib Martin Jansa
2014-01-18 14:02 ` [PATCH 3/5] package.bbclass: add SHLIBSSEARCHDIRS to define where to search for shlib providers Martin Jansa
2014-01-19 17:13   ` Richard Purdie [this message]
2014-01-19 18:55     ` Martin Jansa
2014-01-18 14:02 ` [PATCH 4/5] package.bbclass: Don't search for prividers of PRIVATE_LIBS Martin Jansa
2014-01-18 14:02 ` [PATCH 5/5] package.bbclass: Show which files require given dependency in debug output Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390151625.874.16.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox