From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (dan.rpsys.net [93.97.175.187]) by mail.openembedded.org (Postfix) with ESMTP id 3B1F66E6B7 for ; Tue, 21 Jan 2014 22:42:07 +0000 (UTC) Received: from localhost (dan.rpsys.net [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu4) with ESMTP id s0LMft2R005550; Tue, 21 Jan 2014 22:41:55 GMT X-Virus-Scanned: Debian amavisd-new at dan.rpsys.net Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id IealMCm6Iplj; Tue, 21 Jan 2014 22:41:55 +0000 (GMT) Received: from [192.168.3.10] (rpvlan0 [192.168.3.10]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu1) with ESMTP id s0LMfoTS005547 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 21 Jan 2014 22:41:52 GMT Message-ID: <1390344104.874.132.camel@ted> From: Richard Purdie To: Paul Eggleton Date: Tue, 21 Jan 2014 22:41:44 +0000 In-Reply-To: <2497684.SfSpzyn7iv@peggleto-mobl5.ger.corp.intel.com> References: <1390306673-9822-1-git-send-email-paul.eggleton@linux.intel.com> <52DEF00C.20608@linux.intel.com> <2733074.aO9SOLRWn4@peggleto-mobl5.ger.corp.intel.com> <2497684.SfSpzyn7iv@peggleto-mobl5.ger.corp.intel.com> X-Mailer: Evolution 3.8.4-0ubuntu1 Mime-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] conf/bitbake.conf: default HOMEPAGE to blank instead of unknown X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jan 2014 22:42:07 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Tue, 2014-01-21 at 22:22 +0000, Paul Eggleton wrote: > On Tuesday 21 January 2014 22:12:13 Paul Eggleton wrote: > > Hi Saul, > > > > On Tuesday 21 January 2014 14:09:16 Saul Wold wrote: > > > On 01/21/2014 04:17 AM, Paul Eggleton wrote: > > > > The default value for HOMEPAGE of "unknown" has been in place since the > > > > early OE-Classic days, but it doesn't really make sense - "unknown" is > > > > not a valid URL and it just means we have to explicitly check for this > > > > hardcoded string if we're displaying the value in some form of UI, such > > > > as Toaster. There is some code in the unmaintained oelint.bbclass to > > > > check for this value, presumably on the assumption that the recipe will > > > > explicitly set it to "" if there really isn't a homepage, but looking at > > > > recipes in OE-Core and meta-oe suggests that we haven't been using this > > > > convention for some time (with one exception in the latter) and it's > > > > rather uncommon these days to have no URL to associate with a recipe. > > > > > > > > Signed-off-by: Paul Eggleton > > > > --- > > > > > > > > meta/conf/bitbake.conf | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > > > > index 57668e1..4fb6a1c 100644 > > > > --- a/meta/conf/bitbake.conf > > > > +++ b/meta/conf/bitbake.conf > > > > @@ -241,7 +241,7 @@ This package contains documentation." > > > > > > > > LICENSE = "INVALID" > > > > MAINTAINER = "OE-Core Developers > > > > "> > > > > > > > > -HOMEPAGE = "unknown" > > > > +HOMEPAGE = "" > > > > > > This seems to have caused a couple of problems with shadow-securetty, > > > updaterc and depmodwrapper. > > > > > > There may be more. > > > > Can you perhaps be more specific as to what the problem is? > > Oh, I see, rpmbuild blows up with URL blank. Great :/ > > Let's hold off on this one for now because fixing one or two recipes isn't going > to cover it. I'm perfectly fine with the rpm backend injecting something to deal with this rather than cluttering bitbake.conf or the toaster code. I think cleaning out bitbake.conf is something we need to do more of. SRCREV ??= "INVALID" is on my hitlist (newer bitbake's shouldn't need that). Cheers, Richard