From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pb@pbcl.net>
Received: from hetzner.pbcl.net (mail.pbcl.net [88.198.119.4])
	by mail.openembedded.org (Postfix) with ESMTP id C15EC6C765
	for <openembedded-core@lists.openembedded.org>;
	Thu, 23 Jan 2014 07:14:29 +0000 (UTC)
Received: from [12.157.112.67] (helo=[10.71.2.210])
	by hetzner.pbcl.net with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.80) (envelope-from <pb@pbcl.net>)
	id 1W6EUf-0002tc-3I; Thu, 23 Jan 2014 08:14:29 +0100
Message-ID: <1390461261.24755.12.camel@e130.pbcl.net>
From: Phil Blundell <pb@pbcl.net>
To: Ming Liu <ming.liu@windriver.com>
Date: Thu, 23 Jan 2014 07:14:21 +0000
In-Reply-To: <1390459548-21038-1-git-send-email-ming.liu@windriver.com>
References: <1390459548-21038-1-git-send-email-ming.liu@windriver.com>
Organization: Phil Blundell Consulting Ltd
X-Mailer: Evolution 3.8.5-2+b1 
Mime-Version: 1.0
X-Spam_score: -1.0
X-Spam_score_int: -9
X-Spam_bar: -
X-Spam_report: Spam detection software,
	running on the system "hetzner.pbcl.net", has
	identified this incoming email as possible spam. The original message
	has been attached to this so you can view it (if it isn't spam) or
	label similar future email.  If you have any questions, see
	@@CONTACT_ADDRESS@@ for details.
	Content preview:  On Thu, 2014-01-23 at 14:45 +0800,
	Ming Liu wrote: > > +CACHED_CONFIGUREVARS
	+= "ac_cv_path_BASH=/bin/bash" > > -CACHED_CONFIGUREVARS +=
	"ac_cv_path_BASH=${base_bindir}/bash"
	Why did you change this from ${base_bindir} to a hardcoded path? [...] 
	Content analysis details:   (-1.0 points, 5.0 required)
	pts rule name              description
	---- ----------------------
	--------------------------------------------------
	-1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V2] quilt: add ac_cv_path_BASH to CACHED_CONFIGUREVARS also for native
X-BeenThere: openembedded-core@lists.openembedded.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Patches and discussions about the oe-core layer
	<openembedded-core.lists.openembedded.org>
List-Unsubscribe: <http://lists.openembedded.org/mailman/options/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=unsubscribe>
List-Archive: <http://lists.openembedded.org/pipermail/openembedded-core/>
List-Post: <mailto:openembedded-core@lists.openembedded.org>
List-Help: <mailto:openembedded-core-request@lists.openembedded.org?subject=help>
List-Subscribe: <http://lists.openembedded.org/mailman/listinfo/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Jan 2014 07:14:30 -0000
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On Thu, 2014-01-23 at 14:45 +0800, Ming Liu wrote:
>  
> +CACHED_CONFIGUREVARS += "ac_cv_path_BASH=/bin/bash"
>  
> -CACHED_CONFIGUREVARS += "ac_cv_path_BASH=${base_bindir}/bash"

Why did you change this from ${base_bindir} to a hardcoded path?

p.