Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Jason Wessel <jason.wessel@windriver.com>
Cc: "saul.wold" <saul.wold@intel.com>,
	Openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2 1/6] unfs3: Add a NFSv3 user mode server for use with runqemu
Date: Sat, 01 Feb 2014 09:22:12 +0000	[thread overview]
Message-ID: <1391246532.28575.23.camel@ted> (raw)
In-Reply-To: <1390487566-13569-2-git-send-email-jason.wessel@windriver.com>

Hi Jason,

We're seeing a parallel make race on the autobuilder and it seems its
from this patch:

On Thu, 2014-01-23 at 08:32 -0600, Jason Wessel wrote:
> diff --git a/meta/recipes-devtools/unfs3/unfs3/unfs3_parallel_build.patch b/meta/recipes-devtools/unfs3/unfs3/unfs3_parallel_build.patch
> new file mode 100644
> index 0000000..c7fe3d7
> --- /dev/null
> +++ b/meta/recipes-devtools/unfs3/unfs3/unfs3_parallel_build.patch
> @@ -0,0 +1,36 @@
> +Fix parallel build dependency issue
> +
> +If building with make -j2 the lib.a will not get built in time.
> +
> +Jason Wessel <jason.wessel@windriver.com>
> +
> +Upstream-Status: Pending
> +
> +---
> + Config/Makefile.in |    2 ++
> + Makefile.in        |    3 ++-
> + 2 files changed, 4 insertions(+), 1 deletion(-)
> +
> +--- a/Makefile.in
> ++++ b/Makefile.in
> +@@ -29,7 +29,8 @@ DESTDIR =
> + 
> + VPATH = $(srcdir)
> + 
> +-all: subdirs unfsd$(EXEEXT)
> ++all: subdirs
> ++	$(MAKE) unfsd$(EXEEXT)
> + 
> + unfsd$(EXEEXT): $(OBJS) $(CONFOBJ) $(EXTRAOBJ)
> + 	$(CC) -o $@ $(OBJS) $(CONFOBJ) $(EXTRAOBJ) $(LDFLAGS)
> +--- a/Config/Makefile.in
> ++++ b/Config/Makefile.in
> +@@ -16,6 +16,8 @@ lib.a: $(OBJS)
> + 	$(AR) crs lib.a $(OBJS)
> + 
> + y.tab.h y.tab.c: $(srcdir)/exports.y
> ++
> ++y.tab.c: $(srcdir)/exports.y
> + 	$(YACC) -d $(srcdir)/exports.y
> + 
> + y.tab.o: y.tab.c $(srcdir)/exports.h $(top_srcdir)/nfs.h $(top_srcdir)/mount.h $(top_srcdir)/daemon.h

If you "cd Config; make lex.yy.o" you'll find it errors with y.tab.h not
being found. The reason is the line added above, the y.tab.h dependency
on running YACC is needed.

We're seeing this about once an autobuilder run, e.g.:

http://autobuilder.yoctoproject.org/main/builders/nightly-oecore/builds/7/steps/Building%20Toolchain%20Images_1/logs/stdio

Can we drop this second part of the change?

Cheers,

Richard




  parent reply	other threads:[~2014-02-01  9:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-23 14:32 [PATCH v2 0/6] Replace unfs-server with unfs3 Jason Wessel
2014-01-23 14:32 ` [PATCH v2 1/6] unfs3: Add a NFSv3 user mode server for use with runqemu Jason Wessel
2014-01-23 15:01   ` Phil Blundell
2014-01-23 16:52     ` Jason Wessel
2014-02-01  9:22   ` Richard Purdie [this message]
2014-02-01 14:00     ` Jason Wessel
2014-01-23 14:32 ` [PATCH v2 2/6] unfs3, unfs-server: Replace all instances of unfs-server with unfs3 Jason Wessel
2014-01-23 15:02   ` Phil Blundell
2014-01-23 15:35     ` Jason Wessel
2014-01-23 14:32 ` [PATCH v2 3/6] runqemu: Use the newer unfs3 for serving user space nfs Jason Wessel
2014-01-23 14:32 ` [PATCH v2 4/6] unfs-server: Remove unfs-server recipe and patches Jason Wessel
2014-01-23 14:32 ` [PATCH v2 5/6] runqemu-export-rootfs: update for unfs3 Jason Wessel
2014-01-23 14:32 ` [PATCH v2 6/6] runqemu, runqemu-internal: Allow slirp for NFS and KVM use Jason Wessel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391246532.28575.23.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=Openembedded-core@lists.openembedded.org \
    --cc=jason.wessel@windriver.com \
    --cc=saul.wold@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox