Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Gary Thomas <gary@mlbassoc.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/2] scripts/oe-setup-builddir: Keep track of TEMPLATECONF setting
Date: Mon, 24 Feb 2014 15:37:04 +0000	[thread overview]
Message-ID: <1393256224.31769.11.camel@ted> (raw)
In-Reply-To: <1393255080-12382-3-git-send-email-gary@mlbassoc.com>

On Mon, 2014-02-24 at 08:18 -0700, Gary Thomas wrote:
> Keeping track of the TEMPLATECONF variable in the build
> tree will let this script produce the same output when
> listing 'conf-notes.txt' every time the script is run,
> regardless of whether or not TEMPLATECONF has been provided
> by the user.
> 
> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
> ---
>  scripts/oe-setup-builddir |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/scripts/oe-setup-builddir b/scripts/oe-setup-builddir
> index a869fdc..4322158 100755
> --- a/scripts/oe-setup-builddir
> +++ b/scripts/oe-setup-builddir
> @@ -37,8 +37,16 @@ fi
>  
>  cd "$BUILDDIR"
>  
> +if (test -f "$BUILDDIR/conf/template.conf") then
> +    TEMPLATECONF=$(cat $BUILDDIR/conf/template.conf)
> +fi
> +
>  TEMPLATECONF=${TEMPLATECONF:-meta/conf}
>  
> +if ! (test -f "$BUILDDIR/conf/template.conf") then
> +    echo "$TEMPLATECONF" >$BUILDDIR/conf/template.conf
> +fi
> +

Can you please call this something other than xxx.conf? I don't fancy
someone trying to load this ".conf" file with bitbake...

Since you're also looking in this area, there is one piece I've meant to
add for a long time but never quite got to. I think something like a
hidden top level ".templatepointer" style file might be a good idea for
repos like poky and for anyone else trying to customise the build. This
would allow us to point directly at poky's template configuration files
without having to hack the scripts which is currently what happens
there.

That hacking has long since bothered me, equally, I tend to have more
pressing issues to deal with so its never been done as yet.

Cheers,

Richard








  reply	other threads:[~2014-02-24 15:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24 15:17 [PATCH 0/2] Improve setup scripts Gary Thomas
2014-02-24 15:17 ` [PATCH 1/2] oe-init-build-env: Improve script sourcing detection Gary Thomas
2014-02-24 15:18 ` [PATCH 2/2] scripts/oe-setup-builddir: Keep track of TEMPLATECONF setting Gary Thomas
2014-02-24 15:37   ` Richard Purdie [this message]
2014-02-24 15:42     ` Gary Thomas
2014-02-24 16:13       ` Richard Purdie
2014-02-25  8:34   ` Matthieu CRAPET

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393256224.31769.11.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=gary@mlbassoc.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox