Re: [PATCH 1/1] core-image-lsb: enforce pam as a needed distro feature

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Mon, 2014-03-31 at 12:51 +0300, Cristian Iorga wrote:
> core-image-lsb only gave a warning:
> "WARNING: Building libpam but 'pam' isn't in DISTRO_FEATURES,
> PAM won't work correctly"
> when the proper DISTRO was not set for it.
> default choice would be DISTRO = "poky-lsb",
> but not necessarily, depending on each custom distro.
> 
> This fix will enforce the proper usage of pam
> as a distro feature for core-image-lsb by giving
> an error instead of just a warning.
> 
> Fixes [YOCTO #6073]
> 
> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> ---
>  meta/recipes-extended/images/core-image-lsb.bb | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-extended/images/core-image-lsb.bb b/meta/recipes-extended/images/core-image-lsb.bb
> index ed316a6..ab61c6e 100644
> --- a/meta/recipes-extended/images/core-image-lsb.bb
> +++ b/meta/recipes-extended/images/core-image-lsb.bb
> @@ -9,4 +9,6 @@ IMAGE_INSTALL = "\
>      packagegroup-core-lsb \
>      "
>  
> -inherit core-image
> +inherit core-image distro_features_check
> +
> +REQUIRED_DISTRO_FEATURES = "pam"


I have a feeling the autobuilder builds core-image-lsb in situations
where DISTRO=poky, although I could be wrong. Have you checked?

Cheers,

Richard