From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (dan.rpsys.net [93.97.175.187]) by mail.openembedded.org (Postfix) with ESMTP id 60AE06EBA4 for ; Mon, 31 Mar 2014 16:32:32 +0000 (UTC) Received: from localhost (dan.rpsys.net [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu4) with ESMTP id s2VGVrxv017842; Mon, 31 Mar 2014 17:32:27 +0100 X-Virus-Scanned: Debian amavisd-new at dan.rpsys.net Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 6FRMK_YOzTDT; Mon, 31 Mar 2014 17:32:26 +0100 (BST) Received: from [192.168.3.10] (rpvlan0 [192.168.3.10]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu1) with ESMTP id s2VGWKev017976 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 31 Mar 2014 17:32:21 +0100 Message-ID: <1396283535.14790.78.camel@ted> From: Richard Purdie To: Martin Jansa Date: Mon, 31 Mar 2014 17:32:15 +0100 In-Reply-To: <20140331151018.GG2425@jama> References: <1396275649-32352-1-git-send-email-kai.kang@windriver.com> <1396275649-32352-2-git-send-email-kai.kang@windriver.com> <20140331151018.GG2425@jama> X-Mailer: Evolution 3.8.4-0ubuntu1 Mime-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] nss: avoid to use the hardcode kernel version X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Mar 2014 16:32:33 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Mon, 2014-03-31 at 17:10 +0200, Martin Jansa wrote: > On Mon, Mar 31, 2014 at 10:20:49PM +0800, Kai Kang wrote: > > From: Roy Li > > > > When native package is built, use the uname to return the kernel version. > > > > When target is built, read kernel version from ${STAGING_KERNEL_DIR}/kernel-abiversion > > to avoid to use the hardcode kernel version. > > Doesn't it make nss MACHINE_ARCH like most virtual/kernel providers are? Agreed. I rejected this patch a while ago due to this and I'll reject it again. Cheers, Richard