From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: [PATCH] pixbufcache.bbclass: Fix setscene silent failures
Date: Mon, 31 Mar 2014 23:08:54 +0100 [thread overview]
Message-ID: <1396303734.14790.87.camel@ted> (raw)
Unfortunately gdk-pixbuf-query-loaders can issue errors but still return
success. We therefore check for output and error in the case any output
is issued (normal success does not issue any).
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
Ross: I'm open to better patches ;-)
[I wrote this to debug other problems]
diff --git a/meta/classes/pixbufcache.bbclass b/meta/classes/pixbufcache.bbclass
index 414fd30..88da734 100644
--- a/meta/classes/pixbufcache.bbclass
+++ b/meta/classes/pixbufcache.bbclass
@@ -53,7 +53,11 @@ SSTATEPOSTINSTFUNCS_append_class-native = " pixbufcache_sstate_postinst"
pixbufcache_sstate_postinst() {
if [ "${BB_CURRENTTASK}" = "populate_sysroot" -o "${BB_CURRENTTASK}" = "populate_sysroot_setscene" ]
then
- gdk-pixbuf-query-loaders --update-cache
+ T=`gdk-pixbuf-query-loaders --update-cache 2>&1`
+ if [ -n "$T" ]; then
+ echo $T
+ exit 1
+ fi
fi
}
reply other threads:[~2014-03-31 22:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396303734.14790.87.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox