From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (dan.rpsys.net [93.97.175.187]) by mail.openembedded.org (Postfix) with ESMTP id E703A65D64 for ; Tue, 8 Apr 2014 10:03:28 +0000 (UTC) Received: from localhost (dan.rpsys.net [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu4) with ESMTP id s38A3NxI009117; Tue, 8 Apr 2014 11:03:23 +0100 X-Virus-Scanned: Debian amavisd-new at dan.rpsys.net Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qe62D50aKgsa; Tue, 8 Apr 2014 11:03:23 +0100 (BST) Received: from [192.168.3.10] (rpvlan0 [192.168.3.10]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu1) with ESMTP id s38A3G7w009098 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 8 Apr 2014 11:03:18 +0100 Message-ID: <1396951390.24597.88.camel@ted> From: Richard Purdie To: Ming Liu Date: Tue, 08 Apr 2014 11:03:10 +0100 In-Reply-To: <53435E81.9060308@windriver.com> References: <1396870039-26834-1-git-send-email-ming.liu@windriver.com> <1396870039-26834-3-git-send-email-ming.liu@windriver.com> <1396870587.24597.35.camel@ted> <53435E81.9060308@windriver.com> X-Mailer: Evolution 3.8.4-0ubuntu1 Mime-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 3/3] binconfig.bbclass: fix multilib file conflicts X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Apr 2014 10:03:30 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Tue, 2014-04-08 at 10:27 +0800, Ming Liu wrote: > On 04/07/2014 07:36 PM, Richard Purdie wrote: > > On Mon, 2014-04-07 at 19:27 +0800, Ming Liu wrote: > >> In most cases binconfig files conflict among multilib packages, to avoid > >> that, use update-alternatives link *-config from real path with a > >> PACKAGE_ARCH suffix. > >> > >> Signed-off-by: Ming Liu > >> --- > >> meta/classes/binconfig.bbclass | 65 ++++++++++++++++++++++++++++++++++++------ > >> 1 file changed, 56 insertions(+), 9 deletions(-) > > This isn't going in, its complex and supports a minority use case. > > binconfig should be dying out, not being extended and shored up like > > this. > > > > I'd also add this patch is buggy, its pure luck that update-alternatives > > is available at rootfs generation time since its not in a visible > > dependency. > > > > So going forward I'd like to see patches which simply delete binconfig > > scripts. Where there isn't a .pc alternative we should be adding them > > and pushing them upstream. > Did you mean we'd better remove all *-config scripts, insteaded by > providing .pc files, and send the changes to all upstreams providing and > using *-config? That seems a huge work and we need co-operate with a lot > of projects. Basically, yes, that is what I mean. I might be wrong but I don't think there are that many projects which don't ship .pc files now and just have a binconfig as a backup. Cheers, Richard