From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (dan.rpsys.net [93.97.175.187]) by mail.openembedded.org (Postfix) with ESMTP id E5F2765D4A for ; Wed, 9 Apr 2014 09:28:58 +0000 (UTC) Received: from localhost (dan.rpsys.net [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu4) with ESMTP id s399Sr0x025110; Wed, 9 Apr 2014 10:28:53 +0100 X-Virus-Scanned: Debian amavisd-new at dan.rpsys.net Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 1eIVKG21vLFL; Wed, 9 Apr 2014 10:28:52 +0100 (BST) Received: from [192.168.3.10] (rpvlan0 [192.168.3.10]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-2.1ubuntu1) with ESMTP id s399SoUZ025104 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Wed, 9 Apr 2014 10:28:51 +0100 Message-ID: <1397035724.24597.136.camel@ted> From: Richard Purdie To: Chong Lu Date: Wed, 09 Apr 2014 10:28:44 +0100 In-Reply-To: <5344FB80.2010006@windriver.com> References: <946d60db486d1ac1c5b3aecf64b029e8a15d42de.1396600342.git.Chong.Lu@windriver.com> <1396608067.2910.110.camel@ted> <5343539B.3030808@windriver.com> <1396951684.24597.90.camel@ted> <5344FB80.2010006@windriver.com> X-Mailer: Evolution 3.8.4-0ubuntu1 Mime-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 1/1] kernelshark/trace-cmd: fix syntax error of shell X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Apr 2014 09:29:00 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2014-04-09 at 15:49 +0800, Chong Lu wrote: > On 04/08/2014 06:08 PM, Richard Purdie wrote: > > On Tue, 2014-04-08 at 09:40 +0800, Chong Lu wrote: > >> On 04/04/2014 06:41 PM, Richard Purdie wrote: > >>> On Fri, 2014-04-04 at 16:33 +0800, Chong Lu wrote: > >>>> Delete "<<<" syntax of bash in Makefile, else we would get following error: > >>>> > >>>> Syntax error: redirection unexpected > >>>> > >>>> [YOCTO #6112] > >>>> > >>>> Signed-off-by: Chong Lu > >>>> --- > >>>> meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb | 3 ++- > >>>> .../kernelshark-fix-syntax-error-of-shell.patch | 30 ++++++++++++++++++++++ > >>>> .../trace-cmd-fix-syntax-error-of-shell.patch | 30 ++++++++++++++++++++++ > >>>> meta/recipes-kernel/trace-cmd/trace-cmd_1.2.bb | 1 + > >>>> 4 files changed, 63 insertions(+), 1 deletion(-) > >>>> create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch > >>>> create mode 100644 meta/recipes-kernel/trace-cmd/trace-cmd/trace-cmd-fix-syntax-error-of-shell.patch > >>>> > >>>> diff --git a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb > >>>> index 9268a50..d61097d 100644 > >>>> --- a/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb > >>>> +++ b/meta/recipes-kernel/trace-cmd/kernelshark_1.2.bb > >>>> @@ -15,7 +15,8 @@ inherit pkgconfig pythonnative > >>>> SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git \ > >>>> file://addldflags.patch \ > >>>> file://make-docs-optional.patch \ > >>>> - file://blktrace-api-compatibility.patch" > >>>> + file://blktrace-api-compatibility.patch \ > >>>> + file://kernelshark-fix-syntax-error-of-shell.patch" > >>>> S = "${WORKDIR}/git" > >>>> > >>>> EXTRA_OEMAKE = "'CC=${CC}' 'AR=${AR}' 'prefix=${prefix}' gui" > >>>> diff --git a/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch b/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch > >>>> new file mode 100644 > >>>> index 0000000..994a9fa > >>>> --- /dev/null > >>>> +++ b/meta/recipes-kernel/trace-cmd/trace-cmd/kernelshark-fix-syntax-error-of-shell.patch > >>>> @@ -0,0 +1,30 @@ > >>>> +kernelshark: fix syntax error of shell > >>>> + > >>>> +Delete "<<<" syntax of bash in Makefile, else we would get following error: > >>>> + > >>>> + Syntax error: redirection unexpected > >>>> + > >>>> +Upstream-Status: Inappropriate [embedded specific] > >>> How is this embedded specific? > >>> > >>> Cheers, > >>> > >>> Richard > >> This issue only produced in yocto. > >> It is not problem for kernelshark and trace-cmd itself. > >> So I think this is embedded specific. > > I'm afraid I don't accept this explanation. Is Yocto's make different > > somehow which causes this error? > > > > I don't understand why yocto would see this error yet other systems > > (which use the same make as far as I know) would not. > > > > Cheers, > > > > Richard > > > Hi Richard, > > I built kernelshark and trace-cmd in Ubuntu 12.04. > The dash is default shell in this distrobution. > So, this issue would produce only on host that the default shell is not > bash. Right, so the Upstream-Status is not "embedded specific", its a general problems for shells which are not bash? Cheers, Richard