From: Phil Blundell <pb@pbcl.net>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 4/5] tune-cortexm3.inc: Cortex-M3 doesn't support ARM instructions
Date: Sun, 27 Apr 2014 16:22:45 +0100 [thread overview]
Message-ID: <1398612165.4956.60.camel@e130.pbcl.net> (raw)
In-Reply-To: <3284a4ff6415bb88ec8aee87c5fc098a30156c51.1398443925.git.Martin.Jansa@gmail.com>
On Fri, 2014-04-25 at 18:40 +0200, Martin Jansa wrote:
> Extracted from "Cortex-M3 Technical Reference Manual":
> "The processor implements the ARM v7-M architecture. This includes the entire
> 16-bit Thumb instruction set and the base Thumb-2 32-bit instruction set
> architecture. The processor cannot execute ARM instructions."
This is true, though it's worth noting that the Thumb-only restriction
is generic to ARMv7-M and not specific to Cortex-M3. This tune file
seems to conflate the architecture and the particular CPU slightly and
it seems like some refactoring might be desirable, though obviously that
doesn't make your patch wrong. Also...
> PACKAGE_EXTRA_ARCHS_tune-cortexm3 = "${PACKAGE_EXTRA_ARCHS_tune-armv7at} armv7m-vfp"
... this seems a bit bogus. Presumably
${PACKAGE_EXTRA_ARCHS_tune-armv7at} will include "arm" and a bunch of
other architectures, some of which (e.g. armv4) are more or less
guaranteed to be 32-bit code. Without a wholesale rethink of the way
that PACKAGE_ARCHs are done on arm, it doesn't seem very safe for armv7m
machines to admit any earlier architecture at all in their
PACKAGE_EXTRA_ARCHS.
p.
next prev parent reply other threads:[~2014-04-27 15:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 16:40 [PATCH 0/5] Allow arm tunes which support only thumb Martin Jansa
2014-04-25 16:40 ` [PATCH 1/5] feature-arm-thumb.inc: Replace inner quotes with apostrophes Martin Jansa
2014-04-25 16:40 ` [PATCH 2/5] feature-arm-thumb.inc, arch-armv4.inc: Add "arm" to TUNE_FEATURES Martin Jansa
2014-04-25 16:40 ` [PATCH 3/5] tune-cortexr4.inc: Add thumb and arm " Martin Jansa
2014-04-25 16:40 ` [PATCH 4/5] tune-cortexm3.inc: Cortex-M3 doesn't support ARM instructions Martin Jansa
2014-04-27 15:22 ` Phil Blundell [this message]
2014-04-25 16:40 ` [PATCH 5/5] WIP: feature-arm-thumb.inc: respect ARM_INSTRUCTION_SET when adding thumb suffix Martin Jansa
2014-04-25 17:04 ` Richard Purdie
2014-04-25 18:33 ` Denys Dmytriyenko
2014-04-25 16:51 ` [PATCH 0/5] Allow arm tunes which support only thumb Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398612165.4956.60.camel@e130.pbcl.net \
--to=pb@pbcl.net \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox