Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: Ensuring a task is re-ran when local.conf is updated
Date: Sat, 03 May 2014 10:08:08 +0100	[thread overview]
Message-ID: <1399108088.12731.94.camel@ted> (raw)
In-Reply-To: <CAJTo0Lbb_D7+SOMuPE5fKY52mnHuw=s3Y_0LxOzwsQTQcKsYXg@mail.gmail.com>

On Sat, 2014-05-03 at 10:03 +0100, Burton, Ross wrote:
> On 2 May 2014 23:07, Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> > It may well do and I've realised the issue:
> >
> > codeparser.py:
> > class PythonParser():
> >     getvars = ("d.getVar", "bb.data.getVar", "data.getVar", "d.appendVar", "d.prependVar")
> >
> > we probably need to change this to an .endswith(".getVar", ".appendVar",
> > ".prependVar") type check...
> 
> Could this be the root-cause of so many instances where we've had to
> add explicit hints that variables should be added to the hash?

Is there really "so many"?

In each case we've seen its been due to the code being python that the
parser can't expand. A simple example that trips it up:

a = "FOO"
d.getVar(a)

We've only added in fixups where the missing variables were adequately
explained. The other set of things we manually tune are exclusions since
there are some variables like the build path that we want to actively
exclude.

However the majority of the accesses we make are simple and the parser
can find them...

Cheers,

Richard




  reply	other threads:[~2014-05-03  9:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-02 16:43 Ensuring a task is re-ran when local.conf is updated Paul Barker
2014-05-02 21:34 ` Richard Purdie
2014-05-02 21:51   ` Paul Barker
2014-05-02 22:07     ` Richard Purdie
2014-05-03  9:03       ` Burton, Ross
2014-05-03  9:08         ` Richard Purdie [this message]
2014-05-03 20:46           ` Burton, Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399108088.12731.94.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox