From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id 5294771C54 for ; Tue, 9 Oct 2018 01:55:45 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) by mail1.windriver.com (8.15.2/8.15.1) with ESMTPS id w991tijq023306 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Mon, 8 Oct 2018 18:55:44 -0700 (PDT) Received: from [128.224.162.218] (128.224.162.218) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 8 Oct 2018 18:55:43 -0700 To: Martin Jansa , Richard Purdie References: <7e21f0e0a9d537ea22ccebab46ce5e4f4912d5ba.1538189779.git.Qi.Chen@windriver.com> <9e2836e7ec7b062fe9bcf06a498eea30f983eb65.camel@linuxfoundation.org> From: ChenQi Message-ID: <139fc630-8a63-4de9-acb5-8082d6fbaa04@windriver.com> Date: Tue, 9 Oct 2018 10:01:27 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [128.224.162.218] Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH 1/1] glibc: refresh patch to also fix qemuppc X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 01:55:45 -0000 Content-Type: multipart/alternative; boundary="------------189849758B0BF40FB3C93C77" --------------189849758B0BF40FB3C93C77 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Richard, I'll consider more about maintenance issue next time. Martin, thanks for taking care of this. Best Regards, Chen Qi On 09/29/2018 08:55 PM, Martin Jansa wrote: > I'm refreshing the patch based on feedback from upstream, I'll > integrate the changes for ppc as well. > > On Sat, Sep 29, 2018 at 2:26 PM Richard Purdie > > wrote: > > On Sat, 2018-09-29 at 10:58 +0800, Chen Qi wrote: > > The patch 0031-sysdeps-ieee754-prevent-maybe-uninitialized- > > errors.patch > > did not take into consideration of qemuppc. Refresh it to also fix > > building for qemuppc. > > > > The related error message is like below: > > > > ../sysdeps/ieee754/ldbl-128ibm/e_jnl.c:153:20: error: 'temp' > may be > > used uninitialized in this function [-Werror=maybe-uninitialized] > > > > Signed-off-by: Chen Qi > > > --- > > ...eee754-prevent-maybe-uninitialized-errors.patch | 41 > > +++++++++++++++++----- > > 1 file changed, 32 insertions(+), 9 deletions(-) > > > > diff --git a/meta/recipes-core/glibc/glibc/0031-sysdeps-ieee754- > > prevent-maybe-uninitialized-errors.patch b/meta/recipes- > > core/glibc/glibc/0031-sysdeps-ieee754-prevent-maybe-uninitialized- > > errors.patch > > index b02c4ec..1c5b254 100644 > > --- a/meta/recipes-core/glibc/glibc/0031-sysdeps-ieee754-prevent- > > maybe-uninitialized-errors.patch > > +++ b/meta/recipes-core/glibc/glibc/0031-sysdeps-ieee754-prevent- > > maybe-uninitialized-errors.patch > > @@ -1,4 +1,4 @@ > > -From c6cc5a6ef46837e341fe271b5ffa6def23810082 Mon Sep 17 00:00:00 > > 2001 > > +From 113241a738662854256c5e2e415397721b842862 Mon Sep 17 00:00:00 > > 2001 > > From: Martin Jansa > > > Date: Fri, 14 Sep 2018 23:23:03 +0000 > > Subject: [PATCH] sysdeps/ieee754: prevent maybe-uninitialized > errors > > @@ -21,13 +21,14 @@ Upstream-Status: Submitted > [https://www.sourcewar > > e.org/ml/libc-alpha/2018-09/msg > > > I get nervous when we modify a patch submitted upstream. Was the patch > submitted accepted? Do we need to send this other piece upstream? > > Cheers, > > Richard > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-core > --------------189849758B0BF40FB3C93C77 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
Richard, I'll consider more about maintenance issue next time.
Martin, thanks for taking care of this.

Best Regards,
Chen Qi

On 09/29/2018 08:55 PM, Martin Jansa wrote:
I'm refreshing the patch based on feedback from upstream, I'll integrate the changes for ppc as well.

On Sat, Sep 29, 2018 at 2:26 PM Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
On Sat, 2018-09-29 at 10:58 +0800, Chen Qi wrote:
> The patch 0031-sysdeps-ieee754-prevent-maybe-uninitialized-
> errors.patch
> did not take into consideration of qemuppc. Refresh it to also fix
> building for qemuppc.
>
> The related error message is like below:
>
>   ../sysdeps/ieee754/ldbl-128ibm/e_jnl.c:153:20: error: 'temp' may be
> used uninitialized in this function [-Werror=maybe-uninitialized]
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  ...eee754-prevent-maybe-uninitialized-errors.patch | 41
> +++++++++++++++++-----
>  1 file changed, 32 insertions(+), 9 deletions(-)
>
> diff --git a/meta/recipes-core/glibc/glibc/0031-sysdeps-ieee754-
> prevent-maybe-uninitialized-errors.patch b/meta/recipes-
> core/glibc/glibc/0031-sysdeps-ieee754-prevent-maybe-uninitialized-
> errors.patch
> index b02c4ec..1c5b254 100644
> --- a/meta/recipes-core/glibc/glibc/0031-sysdeps-ieee754-prevent-
> maybe-uninitialized-errors.patch
> +++ b/meta/recipes-core/glibc/glibc/0031-sysdeps-ieee754-prevent-
> maybe-uninitialized-errors.patch
> @@ -1,4 +1,4 @@
> -From c6cc5a6ef46837e341fe271b5ffa6def23810082 Mon Sep 17 00:00:00
> 2001
> +From 113241a738662854256c5e2e415397721b842862 Mon Sep 17 00:00:00
> 2001
>  From: Martin Jansa <Martin.Jansa@gmail.com>
>  Date: Fri, 14 Sep 2018 23:23:03 +0000
>  Subject: [PATCH] sysdeps/ieee754: prevent maybe-uninitialized errors
> @@ -21,13 +21,14 @@ Upstream-Status: Submitted [https://www.sourcewar
> e.org/ml/libc-alpha/2018-09/msg

I get nervous when we modify a patch submitted upstream. Was the patch
submitted accepted? Do we need to send this other piece upstream?

Cheers,

Richard

--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


--------------189849758B0BF40FB3C93C77--