From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: ChenQi <Qi.Chen@windriver.com>
Cc: matt.cowell@nsn.com, openembedded-core@lists.openembedded.org
Subject: Re: [daisy][PATCH 1/1] systemd: do not use alloca() function in case of uclibc
Date: Tue, 03 Jun 2014 11:58:15 +0100 [thread overview]
Message-ID: <1401793095.12440.72.camel@ted> (raw)
In-Reply-To: <538D9363.2020006@windriver.com>
On Tue, 2014-06-03 at 17:20 +0800, ChenQi wrote:
> The use of alloca() was introduced by an oe-specific patch from Khem Raj.
>
> The patch is
> meta/recipes-core/systemd/systemd/systemd-pam-fix-fallocate.patch.
> The upstream status of the above patch is as following.
> Upstream-Status: Denied [no desire for uclibc support]
>
> That's why I use 'Inappropriate [oe specific]' in the Upstream-Status
> field of my patch.
>
> And I just realized I forgot to also patch the journald-kmsg.c file.
> I'll send out a V2.
Please just update that patch then rather than patching code that we've
ready patched. Is this issue uclibc specific?
At the very least information like this needs to be put into the commit
message/patch header.
Cheers,
Richard
next prev parent reply other threads:[~2014-06-03 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 7:42 [daisy][PATCH 0/1] systemd: do not use alloca() function in case of uclibc Chen Qi
2014-06-03 7:42 ` [daisy][PATCH 1/1] " Chen Qi
2014-06-03 9:06 ` Richard Purdie
2014-06-03 9:20 ` ChenQi
2014-06-03 9:36 ` ChenQi
2014-06-03 10:58 ` Richard Purdie [this message]
2014-06-03 11:42 ` Holger Freyther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401793095.12440.72.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=Qi.Chen@windriver.com \
--cc=matt.cowell@nsn.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox