Re: [PATCH RFC 1/3] insane: Split do_package_qa into a separate task (from do_package)

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2014-07-11 at 13:46 -0300, Otavio Salvador wrote:
> On Fri, Jul 11, 2014 at 10:22 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Fri, 2014-07-11 at 09:14 -0300, Otavio Salvador wrote:
> ...
> >> > I would not recommend setting variables in function prepends like this,
> >> > its ugly and error prone, as you've just found out.
> >>
> >> Any suggested better way of to do it?
> >
> > The anonymous python fragment should be fine, it sets the data at the
> > right level, the global recipe level rather than burying it in some
> > task.
> 
> and in case we need to do it for the packages split from the
> do_package_split? Use the hook mechanism?

That will not work, if you set data in the do_package task, the
do_package_q task cannot see it.

You'd probably have to add a prefunc to do_package_qa to set the right
skip variables if you needed to that since the package names wouldn't be
known until then.

Cheers,

Richard