From: Shan Hai <shan.hai@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: [PATCH] grub-core/net/tftp: Fix endianness problem in (ack)
Date: Wed, 16 Jul 2014 11:26:49 +0800 [thread overview]
Message-ID: <1405481209-16891-2-git-send-email-shan.hai@windriver.com> (raw)
In-Reply-To: <1405481209-16891-1-git-send-email-shan.hai@windriver.com>
commit a706f4cc6bddd03e67a66620101209c471177b53 upstream
---
.../tftp-fix-endianness-problem-in-ack.patch | 42 ++++++++++++++++++++++
meta/recipes-bsp/grub/grub_2.00.bb | 1 +
2 files changed, 43 insertions(+)
create mode 100644 meta/recipes-bsp/grub/grub-2.00/tftp-fix-endianness-problem-in-ack.patch
diff --git a/meta/recipes-bsp/grub/grub-2.00/tftp-fix-endianness-problem-in-ack.patch b/meta/recipes-bsp/grub/grub-2.00/tftp-fix-endianness-problem-in-ack.patch
new file mode 100644
index 0000000..c2a75de
--- /dev/null
+++ b/meta/recipes-bsp/grub/grub-2.00/tftp-fix-endianness-problem-in-ack.patch
@@ -0,0 +1,42 @@
+grub-core/net/tftp: Fix endianness problem in (ack)
+
+commit a706f4cc6bddd03e67a66620101209c471177b53 upstream
+
+Signed-off-by: Shan Hai <shan.hai@windriver.com>
+
+diff --git a/ChangeLog b/ChangeLog
+index 81bdae9..c2f42d5 100644
+--- a/ChangeLog
++++ b/ChangeLog
+@@ -1,3 +1,9 @@
++2012-07-02 Vladimir Serbinenko <phcoder@gmail.com>
++
++ * grub-core/net/tftp.c (ack): Fix endianness problem.
++ (tftp_receive): Likewise.
++ Reported by: Michael Davidsaver.
++
+ 2012-06-27 Vladimir Serbinenko <phcoder@gmail.com>
+
+ * configure.ac: Bump version to 2.00.
+diff --git a/grub-core/net/tftp.c b/grub-core/net/tftp.c
+index 9c70efb..d0f39ea 100644
+--- a/grub-core/net/tftp.c
++++ b/grub-core/net/tftp.c
+@@ -143,7 +143,7 @@ ack (tftp_data_t data, grub_uint16_t block)
+
+ tftph_ack = (struct tftphdr *) nb_ack.data;
+ tftph_ack->opcode = grub_cpu_to_be16 (TFTP_ACK);
+- tftph_ack->u.ack.block = block;
++ tftph_ack->u.ack.block = grub_cpu_to_be16 (block);
+
+ err = grub_net_send_udp_packet (data->sock, &nb_ack);
+ if (err)
+@@ -225,7 +225,7 @@ tftp_receive (grub_net_udp_socket_t sock __attribute__ ((unused)),
+ grub_priority_queue_pop (data->pq);
+
+ if (file->device->net->packs.count < 50)
+- err = ack (data, tftph->u.data.block);
++ err = ack (data, data->block + 1);
+ else
+ {
+ file->device->net->stall = 1;
diff --git a/meta/recipes-bsp/grub/grub_2.00.bb b/meta/recipes-bsp/grub/grub_2.00.bb
index ce2d680..374e716 100644
--- a/meta/recipes-bsp/grub/grub_2.00.bb
+++ b/meta/recipes-bsp/grub/grub_2.00.bb
@@ -22,6 +22,7 @@ SRC_URI = "ftp://ftp.gnu.org/gnu/grub/grub-${PV}.tar.gz \
file://check-if-liblzma-is-disabled.patch \
file://fix-issue-with-flex-2.5.37.patch \
file://grub-2.00-add-oe-kernel.patch \
+ file://tftp-fix-endianness-problem-in-ack.patch \
"
SRC_URI[md5sum] = "e927540b6eda8b024fb0391eeaa4091c"
--
1.8.5.2.233.g932f7e4
prev parent reply other threads:[~2014-07-16 3:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 3:26 (No subject) Shan Hai
2014-07-16 3:26 ` Shan Hai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405481209-16891-2-git-send-email-shan.hai@windriver.com \
--to=shan.hai@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox