From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Chen Qi <Qi.Chen@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] package.bbclass: ensure correct modes on directories
Date: Fri, 18 Jul 2014 14:31:49 +0100 [thread overview]
Message-ID: <1405690309.26348.40.camel@ted> (raw)
In-Reply-To: <8a2f5d0e429d76a916afc1177cd0d74acadc20f0.1405562859.git.Qi.Chen@windriver.com>
On Thu, 2014-07-17 at 10:08 +0800, Chen Qi wrote:
> fstat = cpath.stat(src)
> os.mkdir(dest, fstat.st_mode)
> + os.chmod(dest, fstat.st_mode)
This doesn't make sense. Shouldn't the fstat.st_mode to os.mkdir have
taken care of the mode for us?
Cheers,
Richard
prev parent reply other threads:[~2014-07-18 13:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 2:08 [PATCH 0/1] package.bbclass: ensure correct modes on directories Chen Qi
2014-07-17 2:08 ` [PATCH 1/1] " Chen Qi
2014-07-18 13:31 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405690309.26348.40.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=Qi.Chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox