From: Tom Zanussi <tom.zanussi@intel.com>
To: Maciej Borzecki <maciej.borzecki@open-rnd.pl>
Cc: Maciek Borzecki <maciek.borzecki@gmail.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] wic: original fstab restored too early
Date: Wed, 23 Jul 2014 14:21:32 -0500 [thread overview]
Message-ID: <1406143292.6335.27.camel@empanada> (raw)
In-Reply-To: <1405978453-16554-1-git-send-email-maciej.borzecki@open-rnd.pl>
Sorry, I'm not seeing how this fixes the problem (best would be to
explain that in the patch description too), or for that matter, how to
reproduce the problem. Could you elaborate?
Tom
On Mon, 2014-07-21 at 23:34 +0200, Maciej Borzecki wrote:
> Contents of /etc/fstab were restored too early, thus overwriting the
> autogenerated ones.
>
> Signed-off-by: Maciej Borzecki <maciej.borzecki@open-rnd.pl>
> Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
> ---
> scripts/lib/mic/imager/direct.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/lib/mic/imager/direct.py b/scripts/lib/mic/imager/direct.py
> index 2cf4c8d..beae372 100644
> --- a/scripts/lib/mic/imager/direct.py
> +++ b/scripts/lib/mic/imager/direct.py
> @@ -266,7 +266,6 @@ class DirectImageCreator(BaseImageCreator):
> self.bootimg_dir, self.kernel_dir, self.native_sysroot)
>
> fstab = self.__write_fstab(p.get_rootfs())
> - self._restore_fstab(fstab)
>
> self.__instimage.add_partition(int(p.size),
> p.disk,
> @@ -278,6 +277,9 @@ class DirectImageCreator(BaseImageCreator):
> boot = p.active,
> align = p.align,
> part_type = p.part_type)
> +
> + self._restore_fstab(fstab)
> +
> self.__instimage.layout_partitions(self._ptable_format)
>
> self.__imgdir = self.workdir
next prev parent reply other threads:[~2014-07-23 19:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 21:34 [PATCH 1/2] wic: original fstab restored too early Maciej Borzecki
2014-07-21 21:34 ` [PATCH 2/2] wic: --fsoptions handling Maciej Borzecki
2014-07-23 19:59 ` Tom Zanussi
2014-07-24 12:17 ` [PATCH v2] " Maciej Borzecki
2014-07-25 0:17 ` Tom Zanussi
2014-07-23 19:21 ` Tom Zanussi [this message]
2014-07-23 19:37 ` [PATCH 1/2] wic: original fstab restored too early Maciek Borzecki
2014-07-24 12:27 ` [PATCH v2] wic: do not overwrite autogenerated /etc/fstab with original " Maciej Borzecki
2014-07-25 0:49 ` Tom Zanussi
2014-07-25 15:00 ` Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406143292.6335.27.camel@empanada \
--to=tom.zanussi@intel.com \
--cc=maciej.borzecki@open-rnd.pl \
--cc=maciek.borzecki@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox