Re: [PATCH 1/1] insane: add checking to standardize how .bbappend files do FILESEXTRAPATHS

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2014-07-25 at 11:25 -0600, Gary Thomas wrote:
> On 2014-07-22 21:33, Hongxu Jia wrote:
> > When adding patches or config files from bbappend files, it requires
> > the use of FILESEXTRAPATHS, which has been an issue and failure point
> > for people starting to work with bitbake and oe-core.
> >
> > We add checking to standardize how to use FILESEXTRAPATHS. Only the
> > format of:
> >    FILESEXTRAPATHS_append := ":${THISDIR}/Your_Files_Path" or
> >    FILESEXTRAPATHS_prepend := "${THISDIR}/Your_Files_Path:"
> > is acceptable.
> >
> > [YOCTO #5412]
> >
> > Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> > ---
> >   meta/classes/insane.bbclass | 13 +++++++++++++
> >   meta/classes/utils.bbclass  |  2 ++
> >   meta/conf/bitbake.conf      |  2 ++
> >   3 files changed, 17 insertions(+)
> >
> > diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> > index b26216e..6b1c9ad 100644
> > --- a/meta/classes/insane.bbclass
> > +++ b/meta/classes/insane.bbclass
> > @@ -1022,6 +1022,19 @@ python () {
> >       # Check various variables
> >       ###########################################################################
> >
> > +    # Checking ${FILESEXTRAPATHS}
> > +    extrapaths = (d.getVar("FILESEXTRAPATHS", True) or "")
> > +    if '__default' not in extrapaths.split(":"):
> > +        msg = "FILESEXTRAPATHS-variable, must always use _prepend (or _append)\n"
> > +        msg += "type of assignment, and don't forget the colon.\n"
> > +        msg += "Please assign it with the format of:\n"
> > +        msg += "  FILESEXTRAPATHS_append := \":${THISDIR}/Your_Files_Path\" or\n"
> > +        msg += "  FILESEXTRAPATHS_prepend := \"${THISDIR}/Your_Files_Path:\"\n"
> > +        msg += "in your bbappend file\n\n"
> > +        msg += "Your incorrect assignment is:\n"
> > +        msg += "%s\n" % extrapaths
> > +        bb.fatal(msg)
> 
> It sure would have been nice (even polite?) to make this a warning when first
> added.  As is, it's going to break a lot of builds and it will be very tedious
> to fix since the parser will die on the first one it finds :-(

Agreed, I'll change this to a warning.

Cheers,

Richard