Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Chong Lu <Chong.Lu@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] librsvg-native: add --disable-Bsymbolic to configure
Date: Fri, 15 Aug 2014 09:57:24 +0100	[thread overview]
Message-ID: <1408093044.21596.8.camel@ted> (raw)
In-Reply-To: <1408070991-31581-1-git-send-email-Chong.Lu@windriver.com>

On Fri, 2014-08-15 at 10:49 +0800, Chong Lu wrote:
> From: Robert Yang <liezhi.yang@windriver.com>
> 
> The older ld on the host doesn't have the -Bsymbolic-functions option,
> for example, the one on CentOs 5.x, we can disable it for native.
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
> ---
>  meta/recipes-gnome/librsvg/librsvg_2.40.2.bb |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-gnome/librsvg/librsvg_2.40.2.bb b/meta/recipes-gnome/librsvg/librsvg_2.40.2.bb
> index 34d8ca1..6d9fd53 100644
> --- a/meta/recipes-gnome/librsvg/librsvg_2.40.2.bb
> +++ b/meta/recipes-gnome/librsvg/librsvg_2.40.2.bb
> @@ -21,6 +21,7 @@ SRC_URI[archive.md5sum] = "acdecdb9f08f3bf662a68bf7dafb8b82"
>  SRC_URI[archive.sha256sum] = "48049b643294636df7de1a4b997414d699666f5dc44776945c218a257d2a291c"
>  
>  EXTRA_OECONF = "--disable-introspection --disable-vala"
> +EXTRA_OECONF_append_class-native = " --disable-Bsymbolic"
>  
>  PACKAGECONFIG ??= "gdkpixbuf"
>  # The gdk-pixbuf loader
> -

This kind of thing needs a comment explaining why we need it, preferably
giving an example of a host where there is this problem (as well as
binutils version?).

Cheers,

Richard



      reply	other threads:[~2014-08-15  8:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-15  2:49 [PATCH] librsvg-native: add --disable-Bsymbolic to configure Chong Lu
2014-08-15  8:57 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408093044.21596.8.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=Chong.Lu@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox