From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (5751f4a1.skybroadband.com [87.81.244.161]) by mail.openembedded.org (Postfix) with ESMTP id 874F360703 for ; Thu, 4 Sep 2014 08:53:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id s848rbt4019421; Thu, 4 Sep 2014 09:53:37 +0100 Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Bf7EL8tqhBip; Thu, 4 Sep 2014 09:53:37 +0100 (BST) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id s848rZmk019408 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 4 Sep 2014 09:53:36 +0100 Message-ID: <1409820816.12482.30.camel@ted> From: Richard Purdie To: Robert Yang Date: Thu, 04 Sep 2014 09:53:36 +0100 In-Reply-To: <540827B3.50509@windriver.com> References: <030c29236dc8bc0b8df2f9a2973c0997a91023b5.1409813992.git.liezhi.yang@windriver.com> <1409819233.12482.25.camel@ted> <540827B3.50509@windriver.com> X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 1/1] sstate.bbclass: update the timestamps after install X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Sep 2014 08:53:47 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Thu, 2014-09-04 at 16:49 +0800, Robert Yang wrote: > > On 09/04/2014 04:27 PM, Richard Purdie wrote: > > On Thu, 2014-09-04 at 00:05 -0700, Robert Yang wrote: > >> Update the sstate file's timestamps after it is installed, it will be > >> very useful for removing the old sstate file, especially, it's not easy > >> to remove when use the shared SSTATE_DIR, we can easily remove them with > >> this change, for example: > >> > >> $ find state-cache -type f -ctime +10 -exec rm -f {} \; > >> > >> Will remove the sstate file which isn't used by recent 10 days. > >> > >> We can use the -atime, but it is not always available, for example, > >> when mounted with "-o noatime". > >> > >> The touch is a very light weight action, and the > >> scripts/sstate-cache-management.sh also requires this. > >> > >> Signed-off-by: Robert Yang > >> --- > >> meta/classes/sstate.bbclass | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass > >> index ead829e..885912d 100644 > >> --- a/meta/classes/sstate.bbclass > >> +++ b/meta/classes/sstate.bbclass > >> @@ -618,6 +618,7 @@ sstate_unpack_package () { > >> mkdir -p ${SSTATE_INSTDIR} > >> cd ${SSTATE_INSTDIR} > >> tar -xmvzf ${SSTATE_PKG} > >> + touch --no-dereference ${SSTATE_PKG} > >> } > >> > >> BB_HASHCHECK_FUNCTION = "sstate_checkhashes" > > > > At the very least we need to consider read only files here... > > Hello, did you mean the SSTATE_MIRRORS ? I thought that I had > considered it since I used the "touch --no-dereference", > make a clear check is reasonable if I understand correctly, > so updated the code in the repo: (The --no-dereference is not > need any more since the "test -w" follows symlink). We need the --no-dereferece but this could also be a readonly directory or set of readonly files (think an ISO shipped with WR Linux or locked sstate cache). Cheers, Richard