Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Mark Hatle <mark.hatle@windriver.com>
Cc: Otavio Salvador <otavio@ossystems.com.br>,
	Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] toolchain-scripts.bbclass: Allow sourcing of subscript for environment
Date: Fri, 10 Oct 2014 11:37:47 +0100	[thread overview]
Message-ID: <1412937467.10719.5.camel@ted> (raw)
In-Reply-To: <54372DEF.7080101@windriver.com>

On Thu, 2014-10-09 at 19:53 -0500, Mark Hatle wrote:
> On 10/9/14, 7:41 PM, Otavio Salvador wrote:
> > On Thu, Oct 9, 2014 at 8:27 PM, Mark Hatle <mark.hatle@windriver.com> wrote:
> >> On 10/9/14, 4:53 PM, Otavio Salvador wrote:
> >>>
> >>> Sometimes we require extra environment settings to be available on the
> >>> environment for proper SDK work. This were done, in past, using
> >>> '_append' tasks however with the split of the environment in a
> >>> canadian package this has been broken.
> >>>
> >>> The easier and more flexible solution is to use environment subscripts
> >>> which are sources by the main script. These are now looked at:
> >>>
> >>>    $OECORE_NATIVE_SYSROOT/environment-setup.d/*.sh
> >>>
> >>> and sourced.
> >>>
> >>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >>
> >>
> >> I really like this approach.  However, is there any way for the subscripts
> >> to be arch specific?
> >
> > I think we can plan on that but this would be 1.8 material IMO. This
> > is enough for what we need today and can easily be improved in future
> > work. What do you think?
> >
> 
> I think it's a fairly low risk change..  I'm certainly not against it.

We can easily add the target part too, I've just sent out a patch which
does this. I do agree that this is probably a good way forward for being
able to extend the scripts.

Cheers,

Richard



  parent reply	other threads:[~2014-10-10 10:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-09 21:53 [PATCH 1/2] toolchain-scripts.bbclass: Allow sourcing of subscript for environment Otavio Salvador
2014-10-09 21:53 ` [PATCH 2/2] meta-toolchain-qt: Fix environment population Otavio Salvador
2014-10-09 23:27 ` [PATCH 1/2] toolchain-scripts.bbclass: Allow sourcing of subscript for environment Mark Hatle
2014-10-10  0:41   ` Otavio Salvador
2014-10-10  0:53     ` Mark Hatle
2014-10-10 10:36       ` [PATCH] toolchains-scripts: Add support for target environment scripts Richard Purdie
2014-10-10 12:31         ` Otavio Salvador
2014-10-10 10:37       ` Richard Purdie [this message]
2014-10-10 13:17 ` [PATCH 1/2] toolchain-scripts.bbclass: Allow sourcing of subscript for environment Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412937467.10719.5.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=mark.hatle@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox