Re: [PATCH v2 1/3] image_types.bbclass: Respect IMAGE_TYPEDEP dependencies

Otavio Salvador
2014-12-24T16:32:07Z

Hello Richard,

On Wed, Dec 24, 2014 at 6:46 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Tue, 2014-12-09 at 19:07 -0200, Otavio Salvador wrote:
>> The IMAGE_TYPEDEP dependencies also need to be taken into account when
>> building an IMAGE_FSTYPE.
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>> meta/classes/image_types.bbclass | 2 ++
>> 1 file changed, 2 insertions(+)
>
> According to my tests, something in this patch series is causing:
>
> https://autobuilder.yoctoproject.org/main/builders/minnow/builds/137/steps/BuildImages/logs/stdio
> https://autobuilder.yoctoproject.org/main/builders/minnow-lsb/builds/138/steps/BuildImages/logs/stdio
> https://autobuilder.yoctoproject.org/main/builders/nightly-x86/builds/137/steps/BuildImages_1/logs/stdio
> https://autobuilder.yoctoproject.org/main/builders/nightly-x86-64/builds/138/steps/BuildImages_1/logs/stdio
> https://autobuilder.yoctoproject.org/main/builders/nightly-x86-lsb/builds/138/steps/BuildImages_1/logs/stdio
>
> I could reproduce locally just by building anything with a live image
> type and executing do_bootimg. It appears the ".gz" version of the
> initramfs isn't created. You have to force stamps to get the code to
> rerun.

I could reproduce the issue using the 'genericx86' machine.

After some investigation the culprit for the issue has been found.
When I changed the code to account for the base type dependency, I
mistakenly changed the node to use.

So the fix was easy: http://privatepaste.com/4389a3a857

Thanks for the detailed report, this made my life easier when trying
to reproduce the failing case. I have successfully build
core-image-minimal for 'genericx86' and 'imx6qsabresd' machines. The
last was the one which raised the need of base type dependency rework,
by the way.

I sent a v2 patchset with this fixed.

--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750