Re: [PATCH v2 1/3] image_types.bbclass: Respect IMAGE_TYPEDEP dependencies

Richard Purdie
2014-12-24T08:46:25Z

On Tue, 2014-12-09 at 19:07 -0200, Otavio Salvador wrote:
> The IMAGE_TYPEDEP dependencies also need to be taken into account when
> building an IMAGE_FSTYPE.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> meta/classes/image_types.bbclass | 2 ++
> 1 file changed, 2 insertions(+)

According to my tests, something in this patch series is causing:

https://autobuilder.yoctoproject.org/main/builders/minnow/builds/137/steps/BuildImages/logs/stdio
https://autobuilder.yoctoproject.org/main/builders/minnow-lsb/builds/138/steps/BuildImages/logs/stdio
https://autobuilder.yoctoproject.org/main/builders/nightly-x86/builds/137/steps/BuildImages_1/logs/stdio
https://autobuilder.yoctoproject.org/main/builders/nightly-x86-64/builds/138/steps/BuildImages_1/logs/stdio
https://autobuilder.yoctoproject.org/main/builders/nightly-x86-lsb/builds/138/steps/BuildImages_1/logs/stdio

I could reproduce locally just by building anything with a live image
type and executing do_bootimg. It appears the ".gz" version of the
initramfs isn't created. You have to force stamps to get the code to
rerun.

Cheers,

Richard

> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> index 9aee745..24e4bbb 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -21,6 +21,8 @@ def imagetypes_getdepends(d):
> basetype = type[:-len("." + ctype)]
> adddep(d.getVar("COMPRESS_DEPENDS_%s" % ctype, True), deps)
> break
> + for typedepends in (d.getVar("IMAGE_TYPEDEP_%s" % basetype, True) or "").split():
> + adddep(d.getVar('IMAGE_DEPENDS_%s' % typedepends, True) , deps)
> adddep(d.getVar('IMAGE_DEPENDS_%s' % basetype, True) , deps)
>
> depstr = ""