From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (5751f4a1.skybroadband.com [87.81.244.161]) by mail.openembedded.org (Postfix) with ESMTP id 67D7E60024 for ; Tue, 3 Feb 2015 13:21:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id t13DL5m4009228; Tue, 3 Feb 2015 13:21:05 GMT Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id S9fdJwfn4PED; Tue, 3 Feb 2015 13:21:05 +0000 (GMT) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id t13DKrWQ009221 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Tue, 3 Feb 2015 13:21:04 GMT Message-ID: <1422969653.22544.16.camel@linuxfoundation.org> From: Richard Purdie To: Otavio Salvador Date: Tue, 03 Feb 2015 13:20:53 +0000 In-Reply-To: References: <1422873041-19803-1-git-send-email-florian.boor@kernelconcepts.de> <54D0C0B1.1090500@kernelconcepts.de> <54D0C433.50705@kernelconcepts.de> X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH] base.bbclass: Use bb.warn instead of bb.error for deprecation notification. X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2015 13:21:17 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Tue, 2015-02-03 at 11:02 -0200, Otavio Salvador wrote: > On Tue, Feb 3, 2015 at 11:00 AM, Burton, Ross wrote: > > > > On 3 February 2015 at 12:53, Otavio Salvador > > wrote: > >> > >> > last time I checked (some days ago) it was not necessarily fatal. I was > >> > able to > >> > build complete image collecting a pile of PR_INC errors. That's what > >> > confused me... > >> > I'll check if I still have the log on another machine later. > >> > >> Florian has a point here. We should use 'bb.fatal' and abort all build > >> as soon as possible. > > > > > > Its an error in a specific recipe, so why should that abandon the build > > immediately? > > It ends changing the content of the recipe and might raise a rebuild > of several things. Which ends being invalid as PRINC would make an > error in the end. So why not fail soon and ensure it is act upon it > ASAP? It errors during parsing which stops the build going any further. It doesn't really matter whether its a bb.fatal or bb.error, both would have the same effect here which is to stop the build at parse time. It used to be a bb.warn(), people ignored it. Personally I'd like to drop the thing entirely but people wanted an error so we have that now for this release. We're not changing it back to a warn(). Cheers, Richard