From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] wic: bootimg-partition: Stop removing whole workdir
Date: Wed, 04 Feb 2015 17:18:15 -0600 [thread overview]
Message-ID: <1423091895.18649.26.camel@picadillo> (raw)
In-Reply-To: <1423090155-14149-1-git-send-email-alexandre.belloni@free-electrons.com>
On Wed, 2015-02-04 at 23:49 +0100, Alexandre Belloni wrote:
> Stop removing the whole working directory as this is also removing
> eventual previously created partition images, leading to image creation
> failures.
>
I'm surprised - I've never run into a problem like this. Can you give
more details and/or a reproducer?
Thanks,
Tom
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> scripts/lib/wic/plugins/source/bootimg-partition.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/lib/wic/plugins/source/bootimg-partition.py b/scripts/lib/wic/plugins/source/bootimg-partition.py
> index 6ba39a01f700..c5eb7b8b801b 100644
> --- a/scripts/lib/wic/plugins/source/bootimg-partition.py
> +++ b/scripts/lib/wic/plugins/source/bootimg-partition.py
> @@ -66,7 +66,7 @@ class BootimgPartitionPlugin(SourcePlugin):
> - copies all files listed in IMAGE_BOOT_FILES variable
> """
> hdddir = "%s/boot" % cr_workdir
> - rm_cmd = "rm -rf %s" % cr_workdir
> + rm_cmd = "rm -rf %s/boot" % cr_workdir
> exec_cmd(rm_cmd)
>
> install_cmd = "install -d %s" % hdddir
next prev parent reply other threads:[~2015-02-04 23:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 22:49 [PATCH] wic: bootimg-partition: Stop removing whole workdir Alexandre Belloni
2015-02-04 23:18 ` Tom Zanussi [this message]
2015-02-04 23:39 ` Alexandre Belloni
2015-02-05 8:36 ` Maciej Borzecki
2015-02-05 22:01 ` Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423091895.18649.26.camel@picadillo \
--to=tom.zanussi@linux.intel.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox