Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCHv3 00/10] bluez4/bluez5 selection fixing Yocto 5031
Date: Tue, 10 Feb 2015 15:55:31 +0000	[thread overview]
Message-ID: <1423583731.20217.40.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAJTo0LaNQLGjMWDUQr0SMFDDRe3KTH_MxoUbHMJ9ex9W854jKg@mail.gmail.com>

On Tue, 2015-02-10 at 15:43 +0000, Burton, Ross wrote:
> 
> On 8 February 2015 at 21:16, Christopher Larson <clarson@kergoth.com>
> wrote:
>                     DISTRO_FEATURES_append = " bluez5"
>                     PREFERRED_PROVIDER_bluez-hcidump = "bluez5"
>                     PNBLACKLIST[bluez-hcidump] = "superseded by
>                 bluez5"
>                     PNBLACKLIST[gst-plugin-bluetooth] = "dropped from
>                 bluez5"
>                     PNBLACKLIST[bluez4] = "superseded by bluez5"
>
>         For what it's worth, I like the look of this series (and have
>         since they were first posted). Hopefully it gets merged.
>
> My concern with this series is using DISTRO_FEATURES to control what
> version of BlueZ is used in the image.  What makes BlueZ so special
> that it deserves a DISTRO_FEATURE as opposed to a
> PREFERRED_PROVIDER_virtual/bluez or a variable such as BLUEZ_VERSION
> defined in bluetooth.bbclass?

I think that concern has been holding this up for a while but I don't
see a good way to avoid it. I'd observe that:

* DISTRO_FEATURES was created to have a common place to enable/disable 
  things rather than individual variables
* There is precedent for package specific issues in DISTRO_FEATURES 
  (e.g. libc)
* PREFERRED_PROVIDER is not a good match for this problem as the 
  providers are not identical, or a drop in replacement, far from it.

So whilst I understand the concern I think we have to move past that
based on the above.

Cheers,

Richard





  reply	other threads:[~2015-02-10 15:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-08 18:42 [PATCHv3 00/10] bluez4/bluez5 selection fixing Yocto 5031 Peter A. Bigot
2015-02-08 18:42 ` [PATCHv3 01/10] bluez5: upgrade to 5.28 Peter A. Bigot
2015-02-08 18:42 ` [PATCHv3 02/10] bluetooth.bbclass: simplify recipe inference of bluetooth provider Peter A. Bigot
2015-02-08 18:42 ` [PATCHv3 03/10] packagegroup-base: select distro preference for bluez provider Peter A. Bigot
2015-02-08 18:42 ` [PATCHv3 04/10] pulseaudio: " Peter A. Bigot
2015-02-08 18:42 ` [PATCHv3 05/10] qt-mobility: " Peter A. Bigot
2015-02-08 18:42 ` [PATCHv3 06/10] gstreamer1.0-plugins-bad: " Peter A. Bigot
2015-02-08 18:42 ` [PATCHv3 07/10] ofono: " Peter A. Bigot
2015-02-08 18:42 ` [PATCHv3 08/10] neard: " Peter A. Bigot
2015-02-08 18:42 ` [PATCHv3 09/10] libpcap: " Peter A. Bigot
2015-02-08 18:42 ` [PATCHv3 10/10] connman: depend on distro provider of bluez Peter A. Bigot
2015-02-08 21:16 ` [PATCHv3 00/10] bluez4/bluez5 selection fixing Yocto 5031 Christopher Larson
2015-02-10 15:43   ` Burton, Ross
2015-02-10 15:55     ` Richard Purdie [this message]
2015-02-11  0:41     ` Peter A. Bigot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423583731.20217.40.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox