From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <richard.purdie@linuxfoundation.org>
Received: from dan.rpsys.net (5751f4a1.skybroadband.com [87.81.244.161])
	by mail.openembedded.org (Postfix) with ESMTP id 2605B60556
	for <openembedded-core@lists.openembedded.org>;
	Mon, 16 Feb 2015 17:32:19 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id
	t1GHVWUA009377; Mon, 16 Feb 2015 17:32:20 GMT
Received: from dan.rpsys.net ([127.0.0.1])
	by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024)
	with LMTP id didEy0yijCjp; Mon, 16 Feb 2015 17:32:19 +0000 (GMT)
Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0)
	by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id
	t1GHW7OZ009414
	(version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT);
	Mon, 16 Feb 2015 17:32:18 GMT
Message-ID: <1424107927.25541.3.camel@linuxfoundation.org>
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Otavio Salvador <otavio@ossystems.com.br>
Date: Mon, 16 Feb 2015 17:32:07 +0000
In-Reply-To: <CAP9ODKovgahoQk58sMo_hXMkzQFU0qjP1JrazqKo_A7=2UfviQ@mail.gmail.com>
References: <1424103869.25541.1.camel@linuxfoundation.org>
	<CAP9ODKovgahoQk58sMo_hXMkzQFU0qjP1JrazqKo_A7=2UfviQ@mail.gmail.com>
X-Mailer: Evolution 3.12.7-0ubuntu1 
Mime-Version: 1.0
Cc: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] populate_sdk: Handle OLDEST_KERNEL
X-BeenThere: openembedded-core@lists.openembedded.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Patches and discussions about the oe-core layer
	<openembedded-core.lists.openembedded.org>
List-Unsubscribe: <http://lists.openembedded.org/mailman/options/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=unsubscribe>
List-Archive: <http://lists.openembedded.org/pipermail/openembedded-core/>
List-Post: <mailto:openembedded-core@lists.openembedded.org>
List-Help: <mailto:openembedded-core-request@lists.openembedded.org?subject=help>
List-Subscribe: <http://lists.openembedded.org/mailman/listinfo/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=subscribe>
X-List-Received-Date: Mon, 16 Feb 2015 17:32:20 -0000
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

On Mon, 2015-02-16 at 15:07 -0200, Otavio Salvador wrote:
> On Mon, Feb 16, 2015 at 2:24 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > Add a check to the SDK so that it only runs on systems with kernel versions
> > it supports.
> >
> > [YOCTO #6856]
> >
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> >
> > diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
> > index 8b7e9ea..e3adacb 100644
> > --- a/meta/classes/populate_sdk_base.bbclass
> > +++ b/meta/classes/populate_sdk_base.bbclass
> > @@ -126,6 +126,7 @@ EOF
> >         # substitute variables
> >         sed -i -e 's#@SDK_ARCH@#${SDK_ARCH}#g' \
> >                 -e 's#@SDKPATH@#${SDKPATH}#g' \
> > +               -e 's#@OLDEST_KERNEL@#${OLDEST_KERNEL}#g' \
> >                 -e 's#@REAL_MULTIMACH_TARGET_SYS@#${REAL_MULTIMACH_TARGET_SYS}#g' \
> >                 -e '/@SDK_POST_INSTALL_COMMAND@/d' \
> >                 ${SDK_DEPLOY}/${TOOLCHAIN_OUTPUTNAME}.sh
> > diff --git a/meta/files/toolchain-shar-template.sh b/meta/files/toolchain-shar-template.sh
> > index 4a7fbd5..64e87a2 100644
> > --- a/meta/files/toolchain-shar-template.sh
> > +++ b/meta/files/toolchain-shar-template.sh
> > @@ -3,6 +3,24 @@
> >  INST_ARCH=$(uname -m | sed -e "s/i[3-6]86/ix86/" -e "s/x86[-_]64/x86_64/")
> >  SDK_ARCH=$(echo @SDK_ARCH@ | sed -e "s/i[3-6]86/ix86/" -e "s/x86[-_]64/x86_64/")
> >
> > +verlte () {
> > +       [  "$1" = "`printf "$1\n$2" | sort -V | head -n1`" ]
> > +}
> > +
> > +verlt() {
> > +       [ "$1" = "$2" ] && return 1 || verlte $1 $2
> > +}
> > +
> > +verlt `uname -r` @OLDEST_KERNEL@
> > +if [ $? = 0 ]; then
> > +       echo "Error: The SDK needs a kernel > @OLDEST_KERNEL@"
> > +       exit 1
> > +fi
> > +
> > +
> > +verlte `uname -r` 3.18.0 && echo "yes" || echo "no"
> > +verlte 4.16 3.18.0 && echo "yes" || echo "no"
> 
> Is this a development code forgotten? :)

Yes, well spotted, thanks!

I'll remove those two lines

Cheers,

Richard