Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/4] gettext 0.16.1: disable native
Date: Fri, 20 Feb 2015 12:53:03 +0000	[thread overview]
Message-ID: <1424436783.11836.44.camel@linuxfoundation.org> (raw)
In-Reply-To: <54E6C721.7060505@windriver.com>

On Fri, 2015-02-20 at 13:33 +0800, Robert Yang wrote:
> Any comments on the two patches, please ?

Well, I'm not convinced these are correct.

If you have differing native and target gettext versions, I don't think
it will work well and we're storing up potential trouble.

Having said that, I haven't replied so far as you're going to ask how
this breaks and how we fix it and I simply don't know. The patches don't
look/feel right though.

Cheers,

Richard



  reply	other threads:[~2015-02-20 12:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18  3:28 [PATCH 0/4] meta: 4 fixes Robert Yang
2015-02-18  3:28 ` [PATCH 1/4] meta: fix build with gettext 0.16.1 Robert Yang
2015-02-18  3:28 ` [PATCH 2/4] gettext 0.16.1: disable native Robert Yang
2015-02-20  5:33   ` Robert Yang
2015-02-20 12:53     ` Richard Purdie [this message]
2015-02-21  1:57       ` Robert Yang
2015-02-18  3:28 ` [PATCH 3/4] btrfs-tools: fix for parallel build Robert Yang
2015-02-18  3:28 ` [PATCH 4/4] bind: fix paralle issue Robert Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424436783.11836.44.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=liezhi.yang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox