Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Naresh Bhat <naresh.bhat@linaro.org>
Cc: matt.fleming@intel.com, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core v1 PATCH 3/5] bootimg: Skip build iso image for aarch64
Date: Fri, 13 Mar 2015 16:00:15 +0000	[thread overview]
Message-ID: <1426262415.9114.212.camel@linuxfoundation.org> (raw)
In-Reply-To: <1426258527-2329-4-git-send-email-naresh.bhat@linaro.org>

On Fri, 2015-03-13 at 20:25 +0530, Naresh Bhat wrote:
> Build iso image required syslinux package.  We have already skip the syslinux
> package.  Hence just skip the iso image build too.
> 
> Signed-off-by: Naresh Bhat <naresh.bhat@linaro.org>
> ---
>  meta/classes/bootimg.bbclass |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/bootimg.bbclass b/meta/classes/bootimg.bbclass
> index ed7b32f..d8c2a59 100644
> --- a/meta/classes/bootimg.bbclass
> +++ b/meta/classes/bootimg.bbclass
> @@ -265,7 +265,11 @@ python do_bootimg() {
>      if d.getVar("EFI", True) == "1":
>          bb.build.exec_func('build_efi_cfg', d)
>      bb.build.exec_func('build_hddimg', d)
> -    bb.build.exec_func('build_iso', d)
> +
> +    if d.getVar('TARGET_ARCH', True) == "aarch64":
> +            return
> +    else:
> +            bb.build.exec_func('build_iso', d)

Its minor but the else: here is redundant after a return.

Cheers,

Richard





  reply	other threads:[~2015-03-13 16:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13 14:55 [OE-core v1 PATCH 0/5] aarch64 changes for meta layer Naresh Bhat
2015-03-13 14:55 ` [OE-core v1 PATCH 1/5] bootimg: Add support to install Image Naresh Bhat
2015-03-13 14:55 ` [OE-core v1 PATCH 2/5] syslinux: Remove bootimg dependency on aarch64 Naresh Bhat
2015-03-13 15:59   ` Richard Purdie
2015-03-13 17:03     ` Naresh Bhat
2015-03-13 14:55 ` [OE-core v1 PATCH 3/5] bootimg: Skip build iso image for aarch64 Naresh Bhat
2015-03-13 16:00   ` Richard Purdie [this message]
2015-03-13 17:17     ` Bernhard Reutner-Fischer
2015-03-16  7:53       ` Naresh Bhat
2015-03-13 14:55 ` [OE-core v1 PATCH 4/5] grub: Update grub git recipe Naresh Bhat
2015-03-13 16:05   ` Richard Purdie
2015-03-16 11:59     ` Naresh Bhat
2015-03-13 14:55 ` [OE-core v1 PATCH 5/5] grub-efi: Add to support to install grubaa64 efi Naresh Bhat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426262415.9114.212.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=matt.fleming@intel.com \
    --cc=naresh.bhat@linaro.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox