Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Junling Zheng <zhengjunling@huawei.com>
Cc: peifeiyue@huawei.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] file: remove the original magic.h
Date: Thu, 26 Mar 2015 09:54:26 +0000	[thread overview]
Message-ID: <1427363666.14020.62.camel@linuxfoundation.org> (raw)
In-Reply-To: <1427361482-5775-1-git-send-email-zhengjunling@huawei.com>

On Thu, 2015-03-26 at 09:18 +0000, Junling Zheng wrote:
> The magic.h under the src/ directory should be generated by magic.h.in
> during compiling. However, if we modify the magic.h.in, we can find that
> sometimes the magic.h would not be generated again, and then we use the
> original one which is not correct. So remove the original magic.h.
> 
> Signed-off-by: Junling Zheng <zhengjunling@huawei.com>
> ---
>  meta/recipes-devtools/file/file_5.22.bb | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meta/recipes-devtools/file/file_5.22.bb b/meta/recipes-devtools/file/file_5.22.bb
> index 9c6bb38..f4ee31b 100644
> --- a/meta/recipes-devtools/file/file_5.22.bb
> +++ b/meta/recipes-devtools/file/file_5.22.bb
> @@ -22,6 +22,12 @@ inherit autotools
>  
>  FILES_${PN} += "${datadir}/misc/*.mgc"
>  
> +do_configure_prepend() {
> +	if test -f "${B}/src/magic.h"; then
> +		rm -rf ${B}/src/magic.h
> +	fi
> +}
> +

If the task checksums change, ${B} should get entirely wiped out with
recent releases of the build system (e.g. dizzy/fido/master). Which
version was this tested and found to be needed with?

Cheers,

Richard



  reply	other threads:[~2015-03-26  9:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26  9:18 [PATCH] file: remove the original magic.h Junling Zheng
2015-03-26  9:54 ` Richard Purdie [this message]
2015-03-26 11:31   ` Junling Zheng
2015-03-26 11:58     ` Jack Mitchell
2015-03-26 12:58       ` Junling Zheng
2015-03-26 13:08         ` Burton, Ross
2015-03-27  3:31           ` Junling Zheng
2015-03-27  9:56             ` Burton, Ross
2015-03-28  2:36               ` Junling Zheng
2015-03-28  8:53                 ` Richard Purdie
2015-03-28  9:37                   ` Junling Zheng
2015-03-28 11:05                     ` Richard Purdie
2015-03-30  1:49                       ` Junling Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427363666.14020.62.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=peifeiyue@huawei.com \
    --cc=zhengjunling@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox