Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Stephen Holstein <yocto@mashlibs.com>
Cc: redengin <sholstei@yahoo.com>, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] Signed-off-by: redengin <sholstei@yahoo.com>
Date: Thu, 26 Mar 2015 14:15:36 +0000	[thread overview]
Message-ID: <1427379336.14020.92.camel@linuxfoundation.org> (raw)
In-Reply-To: <1427350872-13209-1-git-send-email-yocto@mashlibs.com>

On Thu, 2015-03-26 at 02:21 -0400, Stephen Holstein wrote:
> From: redengin <sholstei@yahoo.com>
> 
> fix for fortran to remove libquadmath dependency
> ---
>  meta/recipes-devtools/gcc/gcc-4.9.inc | 1 +
>  1 file changed, 1 insertion(+)

This says what it does but not why or what testing has been done to
verify this. Last time I checked some architectures require libquadmath
for fortran? The subject line is also incorrect and should be a shortlog
entry of the change, not a Signed-off-by line.

Cheers,

Richard

> diff --git a/meta/recipes-devtools/gcc/gcc-4.9.inc b/meta/recipes-devtools/gcc/gcc-4.9.inc
> index c88a496..cec1862 100644
> --- a/meta/recipes-devtools/gcc/gcc-4.9.inc
> +++ b/meta/recipes-devtools/gcc/gcc-4.9.inc
> @@ -99,6 +99,7 @@ EXTRA_OECONF_BASE = "\
>      --with-cloog=no \
>      --enable-checking=release \
>      --enable-cheaders=c_global \
> +    --disable-libquadmath-support \
>  "
>  
>  EXTRA_OECONF_INITIAL = "\
> -- 
> 1.9.1
> 




      reply	other threads:[~2015-03-26 14:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26  6:21 [PATCH] Signed-off-by: redengin <sholstei@yahoo.com> Stephen Holstein
2015-03-26 14:15 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427379336.14020.92.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=sholstei@yahoo.com \
    --cc=yocto@mashlibs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox