From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH] package_manager: Run createrepo sequentially
Date: Mon, 30 Mar 2015 12:00:18 +0300 [thread overview]
Message-ID: <1427706018-1695-1-git-send-email-ed.bartosh@linux.intel.com> (raw)
Running multiple createrepo in parallel can cause raice conditions
when creating/accessing rpm database. Createrepo fails with the
error "package_manager: rpmdb: BDB0060 PANIC: fatal region error detected"
in such cases.
Running createrepo sequentially should fix the race as rpm database
will not be accessed by multiple createrepo at the same time.
[YOCTO #6571]
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
meta/lib/oe/package_manager.py | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/meta/lib/oe/package_manager.py b/meta/lib/oe/package_manager.py
index c9a8084..c956116 100644
--- a/meta/lib/oe/package_manager.py
+++ b/meta/lib/oe/package_manager.py
@@ -108,25 +108,22 @@ class RpmIndexer(Indexer):
archs = archs.union(set(sdk_pkg_archs))
rpm_createrepo = bb.utils.which(os.getenv('PATH'), "createrepo")
- index_cmds = []
rpm_dirs_found = False
for arch in archs:
arch_dir = os.path.join(self.deploy_dir, arch)
if not os.path.isdir(arch_dir):
continue
- index_cmds.append("%s --update -q %s" % (rpm_createrepo, arch_dir))
-
rpm_dirs_found = True
+ result = create_index("%s --update -q %s" % (rpm_createrepo, arch_dir))
+ if result:
+ bb.fatal(result)
+
if not rpm_dirs_found:
bb.note("There are no packages in %s" % self.deploy_dir)
return
- result = oe.utils.multiprocess_exec(index_cmds, create_index)
- if result:
- bb.fatal('%s' % ('\n'.join(result)))
-
class OpkgIndexer(Indexer):
def write_index(self):
--
2.1.4
next reply other threads:[~2015-03-30 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 9:00 Ed Bartosh [this message]
2015-03-30 9:11 ` [PATCH] package_manager: Run createrepo sequentially Richard Purdie
2015-03-30 9:17 ` Ed Bartosh
2015-03-30 9:20 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427706018-1695-1-git-send-email-ed.bartosh@linux.intel.com \
--to=ed.bartosh@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox