From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0072.outbound.protection.outlook.com [207.46.100.72]) by mail.openembedded.org (Postfix) with ESMTP id 7840960034 for ; Fri, 3 Apr 2015 14:57:26 +0000 (UTC) Received: from BY1PR0701MB1144.namprd07.prod.outlook.com (25.160.105.12) by BY1PR0701MB1143.namprd07.prod.outlook.com (25.160.105.11) with Microsoft SMTP Server (TLS) id 15.1.125.19; Fri, 3 Apr 2015 14:57:27 +0000 Received: from BY1PR0701MB1144.namprd07.prod.outlook.com ([25.160.105.12]) by BY1PR0701MB1144.namprd07.prod.outlook.com ([25.160.105.12]) with mapi id 15.01.0130.020; Fri, 3 Apr 2015 14:57:27 +0000 From: "Krishnanjanappa, Jagadeesh" To: Khem Raj Thread-Topic: [OE-core] [PATCH] valgrind: Add INSANE_SKIP of arch for valgrind and valgrind-dbg Thread-Index: AQHQbbokoquEYwCCw02pIj9ulnIb8507YC0Y Date: Fri, 3 Apr 2015 14:57:26 +0000 Message-ID: <1428073036712.25265@caviumnetworks.com> References: <1428000427-31985-1-git-send-email-jagadeesh.krishnanjanappa@caviumnetworks.com>, <8A26CDB0-D56F-4FBD-8F92-4EF3D4B664F1@gmail.com> In-Reply-To: <8A26CDB0-D56F-4FBD-8F92-4EF3D4B664F1@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [12.108.191.226] authentication-results: lists.openembedded.org; dkim=none (message not signed) header.d=none; x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0701MB1143; x-forefront-antispam-report: BMV:1; SFV:NSPM; SFS:(10009020)(6009001)(377454003)(51704005)(24454002)(110136001)(66066001)(106116001)(50986999)(77156002)(2950100001)(99286002)(122556002)(62966003)(54356999)(36756003)(76176999)(46102003)(87936001)(15975445007)(19580395003)(86362001)(19580405001)(40100003)(102836002)(117636001)(2656002)(1720100001)(575784001)(92566002); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0701MB1143; H:BY1PR0701MB1144.namprd07.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(5002010)(5005006); SRVR:BY1PR0701MB1143; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0701MB1143; x-forefront-prvs: 05352A48BE MIME-Version: 1.0 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2015 14:57:26.4282 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1143 Cc: "openembedded-core@lists.openembedded.org" Subject: Re: [PATCH] valgrind: Add INSANE_SKIP of arch for valgrind and valgrind-dbg X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Apr 2015 14:57:29 -0000 Content-Language: en-US Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable > what is the point of packaging files for which there won=92t be any runti= me >environment. You are just better of removing them. >IMO unless you have multilib environment working >this patch is just relaxing the QA With compilers supporting generation of multilib and yocto framework suppor= ting generation of multilib rootfs, one can have this environment often. In= stead of removing them, as said we can disable them from generation using c= onfigure options. Also the valgrind rpm package do include this files in it= s package. Link: http://www.rpmfind.net//linux/RPM/opensuse/13.2/x86_64/valgrind-3.10.= 0-1.1.x86_64.html Regards, Jagadeesh ________________________________________ From: Khem Raj Sent: Friday, April 3, 2015 8:28 AM To: Krishnanjanappa, Jagadeesh Cc: openembedded-core@lists.openembedded.org Subject: Re: [OE-core] [PATCH] valgrind: Add INSANE_SKIP of arch for valgri= nd and valgrind-dbg > On Apr 2, 2015, at 11:47 AM, Krishnanjanappa, Jagadeesh wrote: > > From: "Krishnanjanappa, Jagadeesh" > > If a complier supports generating 32-bit and 64-bit binaries, then > while building valgrind we have two sets of binaries (32-bit and 64-bit) > being generated. > > Example: With compiler supporting generation of both 32-bit and 64-bit > binaries, and building valgrind in 64-bit mode, we come across following > QA Issue (listing only few of them), > > (snip) > ERROR: QA Issue: Architecture did not match (62 to 3) on ${WORKDIR}/valgr= ind/3.10.1-r0/packages-split/valgrind-dbg/usr/lib64/valgrind/.debug/vgprelo= ad_exp-sgcheck-x86-linux.so > ERROR: QA Issue: Architecture did not match (62 to 3) on ${WORKDIR}/valgr= ind/3.10.1-r0/packages-split/valgrind-dbg/usr/lib64/valgrind/.debug/getoff-= x86-linux > ERROR: QA Issue: Architecture did not match (62 to 3) on ${WORKDIR}/valgr= ind/3.10.1-r0/packages-split/valgrind-dbg/usr/lib64/valgrind/.debug/vgprelo= ad_core-x86-linux.so > ERROR: QA Issue: Architecture did not match (62 to 3) on ${WORKDIR}/valgr= ind/3.10.1-r0/packages-split/valgrind-dbg/usr/lib64/valgrind/.debug/vgprelo= ad_memcheck-x86-linux.so > -- CUT -- > > However, we can build only 64-bit or 32-bit binaries in valgrind using > "--enable-only64bit" and "--enable-only32bit" configure options respectiv= ely. > And the required configure option can be selected based on SITEINFO_BITS,= but > feel that if a compiler supports generation of both type of binaries and = it > may be useful for users to have/execute both type of binaries on multilib > environment. So choosing to pack both types of binaries and skip errors i= f the > architecture type are different using INSANE_SKIP. > what is the point of packaging files for which there won=92t be any runtime= environment. You are just better of removing them. IMO unless you have multilib environment working this patch is just relaxing the QA > Signed-off-by: Krishnanjanappa, Jagadeesh > --- > meta/recipes-devtools/valgrind/valgrind_3.10.1.bb | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/meta/recipes-devtools/valgrind/valgrind_3.10.1.bb b/meta/rec= ipes-devtools/valgrind/valgrind_3.10.1.bb > index bf80b16..eaa64c4 100644 > --- a/meta/recipes-devtools/valgrind/valgrind_3.10.1.bb > +++ b/meta/recipes-devtools/valgrind/valgrind_3.10.1.bb > @@ -32,6 +32,8 @@ SRC_URI[sha256sum] =3D "fa253dc26ddb661b6269df58144eff6= 07ea3f76a9bcfe574b0c7726e1d > COMPATIBLE_HOST =3D '(i.86|x86_64|mips|powerpc|powerpc64).*-linux' > COMPATIBLE_HOST_armv7a =3D 'arm.*-linux' > > +PR =3D "r1" > + > inherit autotools ptest > > EXTRA_OECONF =3D "--enable-tls --without-mpicc" > @@ -52,6 +54,13 @@ RRECOMMENDS_${PN} +=3D "${TCLIBC}-dbg" > > RDEPENDS_${PN}-ptest +=3D " sed perl glibc-utils perl-module-file-glob" > > +# skip checking of the Executable and Linkable Format (ELF) type, bit > +# size, and endianness of any binaries. If a compiler supports > +# generating 32-bit, 64-bit binaries, then we have two sets of > +# binaries i.e 32-bit and 64-bit. > +INSANE_SKIP_${PN} +=3D "arch" > +INSANE_SKIP_${PN}-dbg +=3D "arch" > + > do_compile_ptest() { > oe_runmake check > } > -- > 1.8.2.3 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core