Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCHv2] fontcache: allow to pass different fontconfig cache dir
Date: Thu, 09 Apr 2015 11:12:30 +0100	[thread overview]
Message-ID: <1428574350.6976.6.camel@linuxfoundation.org> (raw)
In-Reply-To: <1428405673-29955-1-git-send-email-Martin.Jansa@gmail.com>

On Tue, 2015-04-07 at 13:21 +0200, Martin Jansa wrote:
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
> v2: added --with-cache-dir to fontconfig EXTRA_OECONF in case that was
>     what Ross wanted
> 
>  meta/classes/fontcache.bbclass                        | 4 ++--
>  meta/recipes-graphics/fontconfig/fontconfig_2.11.1.bb | 4 +++-
>  scripts/postinst-intercepts/update_font_cache         | 4 +---
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/meta/classes/fontcache.bbclass b/meta/classes/fontcache.bbclass
> index dfbdfa1..d122387 100644
> --- a/meta/classes/fontcache.bbclass
> +++ b/meta/classes/fontcache.bbclass
> @@ -8,11 +8,11 @@ inherit qemu
>  
>  FONT_PACKAGES ??= "${PN}"
>  FONT_EXTRA_RDEPENDS ?= "fontconfig-utils"
> -
> +FONTCONFIG_CACHE_DIR ?= "${localstatedir}/cache/fontconfig"
>  fontcache_common() {
>  if [ "x$D" != "x" ] ; then
>  	$INTERCEPT_DIR/postinst_intercept update_font_cache ${PKG} mlprefix=${MLPREFIX} bindir=${bindir} \
> -		libdir=${libdir} base_libdir=${base_libdir} localstatedir=${localstatedir}
> +		libdir=${libdir} base_libdir=${base_libdir} fontconfigcachedir=${FONTCONFIG_CACHE_DIR}
>  else
>  	fc-cache
>  fi
> diff --git a/meta/recipes-graphics/fontconfig/fontconfig_2.11.1.bb b/meta/recipes-graphics/fontconfig/fontconfig_2.11.1.bb
> index 797b321..7c5b4b4 100644
> --- a/meta/recipes-graphics/fontconfig/fontconfig_2.11.1.bb
> +++ b/meta/recipes-graphics/fontconfig/fontconfig_2.11.1.bb
> @@ -37,6 +37,8 @@ DEBIAN_NOAUTONAME_fontconfig-utils = "1"
>  
>  inherit autotools pkgconfig
>  
> -EXTRA_OECONF = " --disable-docs --with-default-fonts=${datadir}/fonts"
> +FONTCONFIG_CACHE_DIR ?= "${localstatedir}/cache/fontconfig"
> +
> +EXTRA_OECONF = " --disable-docs --with-default-fonts=${datadir}/fonts --with-cache-dir=${FONTCONFIG_CACHE_DIR}"
>  
>  BBCLASSEXTEND = "native"
> diff --git a/scripts/postinst-intercepts/update_font_cache b/scripts/postinst-intercepts/update_font_cache
> index 3907f25..c8c6018 100644
> --- a/scripts/postinst-intercepts/update_font_cache
> +++ b/scripts/postinst-intercepts/update_font_cache
> @@ -2,6 +2,4 @@
>  
>  PSEUDO_UNLOAD=1 qemuwrapper -L $D -E LD_LIBRARY_PATH=$D/${libdir}:$D/${base_libdir}\
>  					$D${bindir}/fc-cache --sysroot=$D
> -chown -R root:root $D${localstatedir}/cache/fontconfig
> -
> -
> +chown -R root:root $D${fontconfigcachedir}

This looks better but what sets fontconfigcachedir ?

Cheers,

Richard



  reply	other threads:[~2015-04-09 10:12 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150316174236.48B8050234@opal.openembedded.org>
2015-03-21  2:11 ` [oe-commits] Jonathan Liu : fontcache.bbclass: prepend to PACKAGEFUNCS instead of appending Martin Jansa
2015-03-21  9:29   ` Richard Purdie
2015-03-21 14:55     ` Martin Jansa
2015-03-23 22:21       ` Martin Jansa
2015-03-25 12:11         ` Burton, Ross
2015-03-25 16:12           ` Martin Jansa
2015-03-25 16:18             ` Burton, Ross
2015-03-25 22:14               ` Martin Jansa
2015-03-26 21:39                 ` Burton, Ross
2015-03-29  0:28             ` Martin Jansa
2015-03-29  1:27               ` [PATCH] fontcache: allow to pass different fontconfig cache dir Martin Jansa
2015-03-30 10:47                 ` Burton, Ross
2015-03-30 17:27                   ` Martin Jansa
2015-04-07 11:21                     ` [PATCHv2] " Martin Jansa
2015-04-09 10:12                       ` Richard Purdie [this message]
2015-04-09 11:35                         ` Martin Jansa
2015-04-20 10:16                           ` Martin Jansa
2015-03-30 10:09               ` [oe-commits] Jonathan Liu : fontcache.bbclass: prepend to PACKAGEFUNCS instead of appending Burton, Ross
2015-03-30 16:41                 ` Khem Raj
2015-03-30 16:43                   ` Burton, Ross
2015-03-30 16:47                     ` Khem Raj
2015-03-30 18:46                   ` Martin Jansa
2015-03-30 18:49                     ` Khem Raj
2015-03-30 20:07                       ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428574350.6976.6.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox